[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/emacsql 5da614bc9b 359/427: Drop finalizer use and explici
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/emacsql 5da614bc9b 359/427: Drop finalizer use and explicitely depend on Emacs 25 |
Date: |
Tue, 13 Dec 2022 03:00:04 -0500 (EST) |
branch: elpa/emacsql
commit 5da614bc9b37525a1dd3a2d420b3702215ae49b9
Author: Christopher Wellons <wellons@nullprogram.com>
Commit: Christopher Wellons <wellons@nullprogram.com>
Drop finalizer use and explicitely depend on Emacs 25
Emacs 25 has been released for over a year now. EIEIO has diverged, and
continues to diverge, from Emacs 24, making it more difficult to
support as time goes on.
---
Makefile | 5 ++---
README.md | 2 +-
emacsql.el | 9 +++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index c8eb4c9d1c..f931a0bd73 100644
--- a/Makefile
+++ b/Makefile
@@ -1,17 +1,16 @@
# Clone the two dependencies of this package in sibling directories:
# $ cd ..
# $ git clone https://github.com/cbbrowne/pg.el pg
-# $ git clone https://github.com/skeeto/elisp-finalize finalize
# $ cd -
# $ make
#
# Or set LDFLAGS to point at these packages elsewhere:
-# $ make LDFLAGS='-L path/to/finalize -L path/to/pg'
+# $ make LDFLAGS='-L path/to/pg'
.POSIX:
.SUFFIXES: .el .elc
EMACS = emacs
-LDFLAGS = -L ../finalize -L ../pg
+LDFLAGS = -L ../pg
BATCH = $(EMACS) -batch -Q -L . -L tests $(LDFLAGS)
EL = emacsql-compiler.el \
diff --git a/README.md b/README.md
index 248d68cbf2..54bf1c240a 100644
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@ build tool is required. If your own package depends on
EmacSQL as a
database, this means it doesn't have to rely on the user having any
particular software installed.
-Requires Emacs 24.3 or later.
+Requires Emacs 25 or later.
### Windows Issues
diff --git a/emacsql.el b/emacsql.el
index 83c1b43c9f..0d7cc15f4f 100644
--- a/emacsql.el
+++ b/emacsql.el
@@ -5,7 +5,7 @@
;; Author: Christopher Wellons <wellons@nullprogram.com>
;; URL: https://github.com/skeeto/emacsql
;; Version: 2.0.2
-;; Package-Requires: ((emacs "24.3") (cl-generic "0.3") (cl-lib "0.3")
(finalize "1.0.0"))
+;; Package-Requires: ((emacs "25"))
;;; Commentary:
@@ -63,7 +63,6 @@
(require 'cl-lib)
(require 'cl-generic)
(require 'eieio)
-(require 'finalize)
(require 'emacsql-compiler)
(defgroup emacsql nil
@@ -91,6 +90,7 @@ If nil, wait forever.")
:initform nil
:accessor emacsql-log-buffer
:documentation "Output log (debug).")
+ (finalizer :documentation "Object returned from `make-finalizer'.")
(types :allocation :class
:initform nil
:reader emacsql-types
@@ -221,8 +221,9 @@ specific error conditions."
(defun emacsql-register (connection)
"Register CONNECTION for automatic cleanup and return CONNECTION."
- (finalize-register connection #'emacsql-close (copy-sequence connection))
- connection)
+ (let ((finalizer (make-finalizer (lambda () (emacsql-close connection)))))
+ (prog1 connection
+ (setf (slot-value connection 'finalizer) finalizer))))
;;; Useful macros
- [nongnu] elpa/emacsql 327b09b4b9 348/427: Add support for raw strings and raw parameters (#26, #28)., (continued)
- [nongnu] elpa/emacsql 327b09b4b9 348/427: Add support for raw strings and raw parameters (#26, #28)., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql c93f52159f 347/427: Bump to version 2.0.2., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql e91bac3a20 350/427: Add cl-generic require to emacsql.el (#32)., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql b65c5b03d5 351/427: Fix up Cask file., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql e3bc9b105f 354/427: Finish removing Cask, including updating the README, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 83a278aa6b 356/427: Remove trailing &key in method definition, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 67ca8124bc 425/427: make: Suppress warning about obsolete autoload package, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql e318a6c8f6 426/427: Add new SQLite back-ends, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 9f0a19280c 296/427: Enhance emacsql-with-transaction to retry., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 616dde3752 361/427: An identifier named * means select all columns (#19), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 5da614bc9b 359/427: Drop finalizer use and explicitely depend on Emacs 25,
ELPA Syncer <=
- [nongnu] elpa/emacsql 3b70e8f5dd 366/427: Add support for NUL characters in strings (fixes #42), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 75ac0448a5 364/427: Add support for DISTINCT in aggregate functions (#41), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 8c46fb2c1e 286/427: Drop argument count check since it's wrong., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 641338533c 331/427: Just build SQLite on first connection., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 56a2882936 333/427: Update README for Melpa changes., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 1b37570bf5 352/427: Fix up the Makefile., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 2e9e2d6ba1 390/427: Fix SQL truncated when print-level or print-length are changed, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 50b139443b 414/427: make: Fix compiling and cleaning tests, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 4fe4413994 420/427: Re-indent some data so that machine and human can agree, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 62d3915737 363/427: Update to SQLite 3.22.0 and remove download system (#40), ELPA Syncer, 2022/12/13