[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/emacsql 373975cbcc 387/427: Remove types from cl-defgeneri
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/emacsql 373975cbcc 387/427: Remove types from cl-defgeneric arguments |
Date: |
Tue, 13 Dec 2022 03:00:14 -0500 (EST) |
branch: elpa/emacsql
commit 373975cbccf7776af771e23f86043b236a330702
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Christopher Wellons <wellons@nullprogram.com>
Remove types from cl-defgeneric arguments
Emacs 29 now warns: "Non-symbol arguments to cl-defgeneric".
One could argue that specifying the type is useful to the human
reader; then again cl-defgeneric without a body doesn't implement
a default method, so doing it is also misleading.
Closes #94.
---
emacsql.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacsql.el b/emacsql.el
index b26d97b368..cbc1de6486 100644
--- a/emacsql.el
+++ b/emacsql.el
@@ -136,7 +136,7 @@ MESSAGE should not have a newline on the end."
;;; Sending and receiving
-(cl-defgeneric emacsql-send-message ((connection emacsql-connection) message)
+(cl-defgeneric emacsql-send-message (connection message)
"Send MESSAGE to CONNECTION.")
(cl-defmethod emacsql-send-message :before
@@ -171,7 +171,7 @@ MESSAGE should not have a newline on the end."
(emacsql-type-map (or mask emacsql-type-map)))
(concat (apply #'emacsql-format (emacsql-prepare sql) args) ";")))
-(cl-defgeneric emacsql ((connection emacsql-connection) sql &rest args)
+(cl-defgeneric emacsql (connection sql &rest args)
"Send SQL s-expression to CONNECTION and return the results.")
(cl-defmethod emacsql ((connection emacsql-connection) sql &rest args)
- [nongnu] elpa/emacsql 56a2882936 333/427: Update README for Melpa changes., (continued)
- [nongnu] elpa/emacsql 56a2882936 333/427: Update README for Melpa changes., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 1b37570bf5 352/427: Fix up the Makefile., ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 2e9e2d6ba1 390/427: Fix SQL truncated when print-level or print-length are changed, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 50b139443b 414/427: make: Fix compiling and cleaning tests, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 4fe4413994 420/427: Re-indent some data so that machine and human can agree, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 62d3915737 363/427: Update to SQLite 3.22.0 and remove download system (#40), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql a164ecd9d3 374/427: Implement operator precedence handling, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 214b46f547 372/427: Update documentation for building SQLite backend (#46), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 5f30787890 375/427: Add precedence handling for "between" syntax, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 60b99760c5 371/427: Extend the compiler search to a configurable list (#45), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 373975cbcc 387/427: Remove types from cl-defgeneric arguments,
ELPA Syncer <=
- [nongnu] elpa/emacsql 9dca599616 383/427: Fix whitespace, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 2fa32d2ab7 395/427: Create new log buffer if existing one isn't live anymore, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 374726060d 385/427: Fix buffer struct allocation size (fixes #91), ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql d5c37d905d 379/427: Put emacs-version in path for out-of-package binary, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 1ce92a6f4a 397/427: No longer require emacsql-psql in emacsql-pg, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql d03c1a606f 392/427: Include optional .config.mk in Makefile, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 6622516e15 393/427: Update library headers, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql b405d99aed 408/427: make: Don't use LDFLAGS to set Emacs load-path, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql b907279bab 418/427: Fix docstring of emacsql-sqlite-condition-alist, ELPA Syncer, 2022/12/13
- [nongnu] elpa/emacsql 9ee397b2be 413/427: Whitespace cosmetics, ELPA Syncer, 2022/12/13