emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/emacsql 373975cbcc 387/427: Remove types from cl-defgeneri


From: ELPA Syncer
Subject: [nongnu] elpa/emacsql 373975cbcc 387/427: Remove types from cl-defgeneric arguments
Date: Tue, 13 Dec 2022 03:00:14 -0500 (EST)

branch: elpa/emacsql
commit 373975cbccf7776af771e23f86043b236a330702
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Christopher Wellons <wellons@nullprogram.com>

    Remove types from cl-defgeneric arguments
    
    Emacs 29 now warns: "Non-symbol arguments to cl-defgeneric".
    One could argue that specifying the type is useful to the human
    reader; then again cl-defgeneric without a body doesn't implement
    a default method, so doing it is also misleading.
    
    Closes #94.
---
 emacsql.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacsql.el b/emacsql.el
index b26d97b368..cbc1de6486 100644
--- a/emacsql.el
+++ b/emacsql.el
@@ -136,7 +136,7 @@ MESSAGE should not have a newline on the end."
 
 ;;; Sending and receiving
 
-(cl-defgeneric emacsql-send-message ((connection emacsql-connection) message)
+(cl-defgeneric emacsql-send-message (connection message)
   "Send MESSAGE to CONNECTION.")
 
 (cl-defmethod emacsql-send-message :before
@@ -171,7 +171,7 @@ MESSAGE should not have a newline on the end."
          (emacsql-type-map (or mask emacsql-type-map)))
     (concat (apply #'emacsql-format (emacsql-prepare sql) args) ";")))
 
-(cl-defgeneric emacsql ((connection emacsql-connection) sql &rest args)
+(cl-defgeneric emacsql (connection sql &rest args)
   "Send SQL s-expression to CONNECTION and return the results.")
 
 (cl-defmethod emacsql ((connection emacsql-connection) sql &rest args)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]