[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-remark eb6456d7f9 5/9: docs(notes-sync): add FIXME
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-remark eb6456d7f9 5/9: docs(notes-sync): add FIXME comment for the previous commit |
Date: |
Tue, 27 Dec 2022 19:58:31 -0500 (EST) |
branch: externals/org-remark
commit eb6456d7f99b3dd3361b810959e5134524c18cc7
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>
docs(notes-sync): add FIXME comment for the previous commit
---
org-remark.el | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/org-remark.el b/org-remark.el
index 437b5a894b..16ad4d05c0 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -1078,7 +1078,12 @@ Trigger by on-save of the notes."
(end (cdr location))
(id (plist-get highlight :id))
(ov (org-remark-find-overlay-in beg end id)))
- (delete-overlay ov)
+ ;; FIXME Currently the when clause is used to guard against
+ ;; the case where a highlight overlay is not found. It should
+ ;; be an edge case but the highlight could have moved to a
+ ;; completely new location where the old location does not
+ ;; overlap with the new location at all.
+ (when ov (delete-overlay ov))
(org-remark-highlight-load highlight))))))
(defun org-remark-notes-sync-with-source ()
- [elpa] externals/org-remark updated (a6b79194d8 -> 5fb747a419), ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark 854856059f 8/9: fix: issue #44 change CATEGORY, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark 47918fa751 2/9: feat: sync notes with source, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark cc69b0359b 6/9: fix: inifinate loop when notes = source for notes-sync, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark b6fa1bea1a 4/9: fix: notes-update-source to allow for beg end adjustment, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark f0a4f23911 3/9: feat: notes-source sync setup, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark 2b0ccad245 1/9: refactor: org-remark-highlight-get-text -> notes-get-text, ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark 5fb747a419 9/9: Merge branch 'notes-sync', ELPA Syncer, 2022/12/27
- [elpa] externals/org-remark eb6456d7f9 5/9: docs(notes-sync): add FIXME comment for the previous commit,
ELPA Syncer <=
- [elpa] externals/org-remark 00e56e12a6 7/9: fix: text-property org-remark-label to be symbol, ELPA Syncer, 2022/12/27