[elpa] externals/consult 7083bd6097 3/4: Replace consult--overlay macro with function

[ELPA Syncer]

branch: externals/consult
commit 7083bd6097462837835a8d7125de439710be24a4
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Replace consult--overlay macro with function
---
 consult.el | 47 ++++++++++++++++++++++-------------------------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/consult.el b/consult.el
index 80cbb935f5..cbea352e08 100644
--- a/consult.el
+++ b/consult.el
@@ -786,16 +786,13 @@ When no project is found and MAY-PROMPT is non-nil ask 
the user."
 (define-obsolete-function-alias
   'consult--format-location 'consult--format-file-line-match "0.31")
 
-(defmacro consult--overlay (beg end &rest props)
+(defun consult--make-overlay (beg end &rest props)
   "Make consult overlay between BEG and END with PROPS."
-  (let ((ov (make-symbol "ov"))
-        (puts))
+  (let ((ov (make-overlay beg end)))
     (while props
-      (push `(overlay-put ,ov ,(car props) ,(cadr props)) puts)
+      (overlay-put ov (car props) (cadr props))
       (setq props (cddr props)))
-    `(let ((,ov (make-overlay ,beg ,end)))
-       ,@puts
-       ,ov)))
+    ov))
 
 (defun consult--remove-dups (list)
   "Remove duplicate strings from LIST."
@@ -1409,20 +1406,20 @@ The function can be used as the `:state' argument of 
`consult--read'."
                         (let ((vbeg (progn (beginning-of-visual-line) (point)))
                               (vend (progn (end-of-visual-line) (point)))
                               (end (pos-eol)))
-                          (consult--overlay vbeg (if (= vend end) (1+ end) 
vend)
-                                            'face 'consult-preview-line
-                                            'window (selected-window)
-                                            'priority 1)))
-                      (consult--overlay (point) (1+ (point))
-                                        'face 'consult-preview-cursor
-                                        'window (selected-window)
-                                        'priority 3)))
+                          (consult--make-overlay vbeg (if (= vend end) (1+ 
end) vend)
+                                                 'face 'consult-preview-line
+                                                 'window (selected-window)
+                                                 'priority 1)))
+                      (consult--make-overlay (point) (1+ (point))
+                                             'face 'consult-preview-cursor
+                                             'window (selected-window)
+                                             'priority 3)))
           (dolist (match (cdr-safe cand))
-            (push (consult--overlay (+ (point) (car match))
-                                    (+ (point) (cdr match))
-                                    'face 'consult-preview-match
-                                    'window (selected-window)
-                                    'priority 2)
+            (push (consult--make-overlay (+ (point) (car match))
+                                         (+ (point) (cdr match))
+                                         'face 'consult-preview-match
+                                         'window (selected-window)
+                                         'priority 2)
                   overlays))
           (run-hooks 'consult-after-jump-hook))))))
 
@@ -1710,7 +1707,7 @@ This command is used internally by the narrowing system 
of `consult--read'."
     (delete-overlay consult--narrow-overlay))
   (when consult--narrow
     (setq consult--narrow-overlay
-          (consult--overlay
+          (consult--make-overlay
            (1- (minibuffer-prompt-end)) (minibuffer-prompt-end)
            'before-string
            (propertize (format " [%s]" (alist-get consult--narrow
@@ -2863,9 +2860,9 @@ of functions and in `consult-completion-in-region'."
           (setq ov nil))
          ((and (eq action 'preview) cand)
           (unless ov
-            (setq ov (consult--overlay start end
-                                       'invisible t
-                                       'window (selected-window))))
+            (setq ov (consult--make-overlay start end
+                                            'invisible t
+                                            'window (selected-window))))
           ;; Use `add-face-text-property' on a copy of "cand in order to merge 
face properties
           (setq cand (copy-sequence cand))
           (add-face-text-property 0 (length cand) 'consult-preview-insertion t 
cand)
@@ -3514,7 +3511,7 @@ INITIAL is the initial input."
                              (let ((a (if not block-beg block-end))
                                    (b (if not block-end beg)))
                                (when (/= a b)
-                                 (push (consult--overlay a b 'invisible t) 
new-overlays)))
+                                 (push (consult--make-overlay a b 'invisible 
t) new-overlays)))
                              (setq block-beg beg))
                            (setq block-end end old-ind ind)))))
                    'commit)