[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/emms 83eb289ce0 3/5: * emms-mpris.el: Fix two issues wi
From: |
ELPA Syncer |
Subject: |
[elpa] externals/emms 83eb289ce0 3/5: * emms-mpris.el: Fix two issues with artUrl metadata |
Date: |
Tue, 7 Feb 2023 15:58:03 -0500 (EST) |
branch: externals/emms
commit 83eb289ce0d5c6b0f684455ef766603f86888d54
Author: Fran Burstall <fran.burstall@gmail.com>
Commit: Fran Burstall <fran.burstall@gmail.com>
* emms-mpris.el: Fix two issues with artUrl metadata
1. We need a graphical display to compute this (due to an
eventual use of image-size): check for this.
2. Better (more correct) url format: file:///path/to/cover-art
---
emms-mpris.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/emms-mpris.el b/emms-mpris.el
index 791ada7b4b..eb311d0d55 100644
--- a/emms-mpris.el
+++ b/emms-mpris.el
@@ -50,6 +50,7 @@
(require 'cl-lib)
(require 'pcase)
(require 'subr-x)
+(require 'seq)
;;* Dbus components
(defconst emms-mpris-service "org.mpris.MediaPlayer2.emms"
@@ -437,8 +438,11 @@ Each entry of the form (info-field mpris-field
dbus-type).")
;; url
(push (emms-mpris-dict "xesam:url" (url-encode-url (concat "file:"
track-name))) metadata)
;; artUrl
- (when-let ((art-file (emms-browser-get-cover-from-path track-name
'medium)))
- (push (emms-mpris-dict "mpris:artUrl" (url-encode-url (concat "file:"
art-file))) metadata))
+ ;; Shockingly, emms-browser-get-cover-from-path needs a graphical display
to
+ ;; function (it eventually calls image-size) so we check there is one...
+ (when (seq-some #'display-graphic-p (frame-list))
+ (when-let ((art-file (emms-browser-get-cover-from-path track-name
'medium)))
+ (push (emms-mpris-dict "mpris:artUrl" (url-encode-url (concat "file://"
art-file))) metadata)))
;; length
(push
(emms-mpris-dict "mpris:length"