emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/embark 1f6c87d79f: Better fix for dired reusing export


From: ELPA Syncer
Subject: [elpa] externals/embark 1f6c87d79f: Better fix for dired reusing export buffers (#527)
Date: Sat, 11 Feb 2023 18:57:35 -0500 (EST)

branch: externals/embark
commit 1f6c87d79f5d138cd128c230d727c796b4bc46cd
Author: Omar Antolín Camarena <omar.antolin@gmail.com>
Commit: Omar Antolín Camarena <omar.antolin@gmail.com>

    Better fix for dired reusing export buffers (#527)
    
    This also fixes #598.
---
 embark.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/embark.el b/embark.el
index f9c8165b91..7d2da2f949 100644
--- a/embark.el
+++ b/embark.el
@@ -3242,6 +3242,8 @@ PRED is a predicate function used to filter the items."
            `((predicate . (member (buffer-name) ',buffers)))))
 
 (autoload 'dired-check-switches "dired")
+(declare-function dired-unadvertise "dired")
+(defvar dired-directory)
 
 (defun embark-export-dired (files)
   "Create a Dired buffer listing FILES."
@@ -3258,8 +3260,9 @@ PRED is a predicate function used to filter the items."
                (cons (expand-file-name dir)
                      (mapcar (lambda (file) (string-remove-prefix dir file))
                              files)))))
+    ;; unadvertise this buffer to avoid reuse
     (with-current-buffer buf
-      (setq-local dired-directory nil)
+      (dired-unadvertise (car dired-directory)) ; avoid reuse of this buffer
       (rename-buffer (format "*Embark Export Dired %s*" default-directory)))
     (pop-to-buffer buf)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]