[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/urgrep c15be33112 076/115: Wrap shell argument quoting
|
From: |
ELPA Syncer |
|
Subject: |
[elpa] externals/urgrep c15be33112 076/115: Wrap shell argument quoting with `with-connection-local-variables` |
|
Date: |
Wed, 10 May 2023 03:00:46 -0400 (EDT) |
branch: externals/urgrep
commit c15be33112948d75711f015c0e6bc4cf6d9b0d79
Author: Jim Porter <jporterbugs@gmail.com>
Commit: Jim Porter <jporterbugs@gmail.com>
Wrap shell argument quoting with `with-connection-local-variables`
This ensures that we use the correct style of quoting for the system in
question, whether remote or local.
---
urgrep.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/urgrep.el b/urgrep.el
index 69dc75546f..79449de4de 100644
--- a/urgrep.el
+++ b/urgrep.el
@@ -488,10 +488,12 @@ COLOR: non-nil (the default) if the output should use
color."
(let* ((prop (intern (concat (symbol-name k) "-arguments")))
(args (urgrep--get-prop-pcase prop tool v)))
(setq arguments (cl-substitute args k arguments))))
- ;; FIXME: Inside compile and dired buffers, `shell-quote-argument'
- ;; doesn't handle TRAMP right...
(setq arguments (flatten-list arguments))
- (mapconcat #'urgrep--maybe-shell-quote-argument arguments " ")))))
+ ;; XXX: Should we wrap more code with
`with-connection-local-variables'?
+ ;; There might be some other variables we use that would benefit from
+ ;; being connection-local aware...
+ (with-connection-local-variables
+ (mapconcat #'urgrep--maybe-shell-quote-argument arguments " "))))))
;; urgrep-mode
- [elpa] externals/urgrep bf24dac2ac 025/115: Allow for separate before/after contexts, (continued)
- [elpa] externals/urgrep bf24dac2ac 025/115: Allow for separate before/after contexts, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep f2ba643f35 028/115: Typo, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep c26ff9b22b 029/115: Add note about grep issues on MS Windows, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 6f50ef99d3 032/115: Remove urgrep--to-command, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 3599ad1a56 033/115: Update comment, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep ba2b01b91b 042/115: Remove no-longer-needed `post-arguments', ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 3643c933c4 055/115: Add support for ugrep, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 0de93bfdb9 068/115: Fix use of wgrep on long urgrep results, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep e2e8898ab2 074/115: Update copyright, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 0c966b2001 075/115: Ensure `default-directory' stays in sync, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep c15be33112 076/115: Wrap shell argument quoting with `with-connection-local-variables`,
ELPA Syncer <=
- [elpa] externals/urgrep e63c6c5173 089/115: Add link to wgrep package and clarify the README, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 61478da305 077/115: Improve reliability of running urgrep over Tramp, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 77fcfc1916 090/115: Use `push` instead of `add-to-list`, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 559b2c07cd 091/115: Add a unit test for getting the preferred tool on multiple hosts, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep fe13a3cbb5 081/115: Fix project-root call on Emacs 27, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep f2c87e7520 080/115: Improve robustness of tests for grep command generation, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep b03a3d84ec 098/115: Add `suffix` argument to `urgrep--get-prop(-pcase)?`, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep eb5191bfd5 097/115: Update copyright year, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 43c82e84ec 082/115: Add CI for Emacs 27.1, ELPA Syncer, 2023/05/10
- [elpa] externals/urgrep 3082d89bd9 099/115: Add support for abbreviating the command in urgrep buffers, ELPA Syncer, 2023/05/10