[elpa] externals/hyperbole f6e9cb1604 2/3: Fix a number of byte-compilation warnings

[ELPA Syncer]

branch: externals/hyperbole
commit f6e9cb16049832105bad50fabddf053550e1e95d
Author: Robert Weiner <rsw@gnu.org>
Commit: Robert Weiner <rsw@gnu.org>

    Fix a number of byte-compilation warnings
---
 ChangeLog       | 10 ++++++++++
 hibtypes.el     |  4 ++--
 hsys-youtube.el |  6 +++++-
 hypb.el         | 12 ++++++------
 4 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index cf91534e6a..4274b8d878 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2023-05-14  Bob Weiner  <rsw@gnu.org>
 
+* hibtypes.el (action): Remove unneeded comma before args that triggered
+    byte compilation error.
+
+* hsys-youtube.el: Add magic autoload comments for internal functions
+    since defact and defalias autoloads do not actually load the library
+    but simply define themselves.
+
+* hypb.el (hypb:oct-to-int): Change mapconcat to mapc since don't use result.
+    Silences byte-compiler warning.
+
 * kotl/kexport.el (kexport:font-awesome-css-include-with-menus): Fix font size
     at 20px for all elements, so is large enough by default.
 
diff --git a/hibtypes.el b/hibtypes.el
index 1c49ca0005..4f260be2c4 100644
--- a/hibtypes.el
+++ b/hibtypes.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    19-Sep-91 at 20:45:31
-;; Last-Mod:      7-May-23 at 13:23:19 by Bob Weiner
+;; Last-Mod:     14-May-23 at 10:57:23 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -1551,7 +1551,7 @@ arg1 ... argN '>'.  For example, <mail nil 
\"user@somewhere.org\">."
                  #'actype:eval)))
           (if (eq hrule:action #'actype:identity)
               `(hact ,actype ,@args)
-            `(hact ,actype ,@(mapcar #'eval ,args))))))))
+            `(hact ,actype ,@(mapcar #'eval args))))))))
 
 (defun action:help (hbut)
   "Display documentation for action button at point.
diff --git a/hsys-youtube.el b/hsys-youtube.el
index 36180a2c19..4c49e7fd04 100644
--- a/hsys-youtube.el
+++ b/hsys-youtube.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    10-Jul-22 at 18:10:56
-;; Last-Mod:     14-May-23 at 02:09:33 by Bob Weiner
+;; Last-Mod:     14-May-23 at 11:27:53 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -150,6 +150,7 @@ Called when the Assist Key is pressed on such a button."
 ;;; Private functions
 ;;; ************************************************************************
 
+;;;###autoload
 (defun hsys-youtube-end-url (video-id &optional start-time-string 
end-time-string)
   "Return url to play VIDEO-ID from optional START-TIME-STRING to 
END-TIME-STRING.
 VIDEO-ID must be a string and can be a video identifier,
@@ -175,6 +176,7 @@ e.g. WkwZHSbHmPg, or a full url to the video."
            ;; replay, so add unused random parameter.
            (random 10000000))))
 
+;;;###autoload
 (defun hsys-youtube-start-url (video-id &optional start-time-string)
   "Return url to play VIDEO-ID starting at beginning or optional 
START-TIME-STRING.
 VIDEO-ID must be a string and can be a video identifier,
@@ -192,6 +194,7 @@ e.g. WkwZHSbHmPg, or a full url to the video."
          (format (concat video-id "&t=%s") start-time-string))
       (format hsys-youtube-start-format video-id start-time-string))))
 
+;;;###autoload
 (defun hsys-youtube-time-in-hms (start-time-string)
   "Return the start time for a Youtube url from START-TIME-STRING.
 Start time is returned as hours, minutes and seconds.
@@ -215,6 +218,7 @@ format is invalid, return it unchanged."
               (concat part1 "h" part2 "m" part3 "s"))))
     start-time-string))
 
+;;;###autoload
 (defun hsys-youtube-time-in-seconds (start-time-string)
   "Return the number of seconds time for a Youtube url given a 
START-TIME-STRING.
 Hours and minutes are optional within the START-TIME-STRING,
diff --git a/hypb.el b/hypb.el
index 24c0035d8e..71e8712d44 100644
--- a/hypb.el
+++ b/hypb.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:     6-Oct-91 at 03:42:38
-;; Last-Mod:     19-Apr-23 at 22:27:32 by Bob Weiner
+;; Last-Mod:     14-May-23 at 10:51:09 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -1045,11 +1045,11 @@ Without file, the banner is prepended to the current 
buffer."
        (dec-num 0))
     (and (string-match "[^0-7]" oct-str)
         (error "(hypb:oct-to-int): Bad octal number: %s" oct-str))
-    (mapconcat (lambda (o)
-                (setq dec-num (+ (* dec-num 8)
-                                 (when (and (>= o ?0) (<= o ?7))
-                                   (- o ?0)))))
-              oct-str "")
+    (mapc (lambda (o)
+           (setq dec-num (+ (* dec-num 8)
+                            (when (and (>= o ?0) (<= o ?7))
+                              (- o ?0)))))
+         oct-str "")
     dec-num))
 
 ;;; ************************************************************************