emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 3dcabed9bd 2/2: Let helm-find-files-do-action obeying


From: ELPA Syncer
Subject: [nongnu] elpa/helm 3dcabed9bd 2/2: Let helm-find-files-do-action obeying dired-create-destination-dirs
Date: Wed, 24 May 2023 15:02:01 -0400 (EDT)

branch: elpa/helm
commit 3dcabed9bd9aaf14d2ae47282e78508b5ba14077
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Let helm-find-files-do-action obeying dired-create-destination-dirs
    
    Before existence of this var Helm behavior was asking, so keeping it
    like this and fixing it for dired users in dired-create-files may
    result in calling twice the y-or-n-p and make-directory, so either
    let-bind to nil (previous commit) or better lets dired-create-files
    (or its async counterpart fixed today) doing the job.
---
 helm-files.el | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/helm-files.el b/helm-files.el
index 1ccb80a332..5667aa7fc3 100644
--- a/helm-files.el
+++ b/helm-files.el
@@ -1182,7 +1182,6 @@ ACTION can be `rsync' or any action supported by 
`helm-dired-action'."
          ;; If HFF is using a frame use a frame as well.
          (helm-actions-inherit-frame-settings t)
          helm-use-frame-when-more-than-two-windows
-         dired-create-destination-dirs
          (dest (or target
                    (with-helm-display-marked-candidates
                      helm-marked-buffer-name
@@ -1196,12 +1195,7 @@ ACTION can be `rsync' or any action supported by 
`helm-dired-action'."
                                               (if 
helm-ff-transformer-show-only-basename
                                                   (helm-basename cand) cand))))
                         :initial-input (helm-dwim-target-directory)
-                        :history (helm-find-files-history nil :comp-read 
nil))))))
-         (dest-dir-p (file-directory-p dest))
-         (dest-dir   (helm-basedir dest)))
-    (unless (or dest-dir-p (file-directory-p dest-dir))
-      (when (y-or-n-p (format "Create directory `%s'? " dest-dir))
-        (make-directory dest-dir t)))
+                        :history (helm-find-files-history nil :comp-read 
nil)))))))
     (if (eq action 'rsync)
         (helm-rsync-copy-files ifiles dest rsync-switches)
       (helm-dired-action



reply via email to

[Prev in Thread] Current Thread [Next in Thread]