[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] scratch/hyperbole 8894d83051 04/15: (kotl-mode:pre-self-insert-co
From: |
Stefan Monnier |
Subject: |
[elpa] scratch/hyperbole 8894d83051 04/15: (kotl-mode:pre-self-insert-command): Use buffer-locally at top-level |
Date: |
Mon, 29 May 2023 23:02:00 -0400 (EDT) |
branch: scratch/hyperbole
commit 8894d83051f90b977c05d4d4bdd5e80877c93db0
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
(kotl-mode:pre-self-insert-command): Use buffer-locally at top-level
* kotl/kotl-mode.el (kotl-mode): Don't impose our `pre-command-hook` on
all buffers.
(kotl-mode:pre-self-insert-command): Remove now-redundant test that
we're in a Kotl buffer. Remove also `hyperb:stack-frame` test which
seems to have been added while debugging a problem around May 2021.
---
kotl/kotl-mode.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/kotl/kotl-mode.el b/kotl/kotl-mode.el
index 89cd6d46f4..d52e516d51 100644
--- a/kotl/kotl-mode.el
+++ b/kotl/kotl-mode.el
@@ -131,7 +131,7 @@ It provides the following keys:
;;
;; Prevent insertion of characters outside of editable bounds,
;; e.g. after the mouse sets point to a non-editable position
- (add-hook 'pre-command-hook #'kotl-mode:pre-self-insert-command)
+ (add-hook 'pre-command-hook #'kotl-mode:pre-self-insert-command nil t)
;;
;; Ensure that outline structure data is saved when save-buffer is called
;; from save-some-buffers, {C-x s}.
@@ -3318,10 +3318,14 @@ Mouse may have moved point outside of an editable area.
kotl-mode:self-insert-command
orgtbl-self-insert-command
self-insert-command))
- (eq major-mode 'kotl-mode)
(not (kview:valid-position-p))
;; Prevent repeatedly moving point to valid position when moving trees
- (not (hyperb:stack-frame '(kcell-view:to-label-end))))
+ ;; FIXME: This may have been useful in some older version of
+ ;; the code but now that it runs from a `pre-command-hook',
+ ;; `kcell-view:to-label-end' can never be in the call
+ ;; stack (except of course during debugging and such).
+ ;;(not (hyperb:stack-frame '(kcell-view:to-label-end)))
+ )
(kotl-mode:to-valid-position)))
(defun kotl-mode:print-attributes (_kview)
- [elpa] branch scratch/hyperbole created (now 4bdcd214e3), Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 1ddb9d3ad5 02/15: * hversion.el (hyperb:path-being-loaded): Delete function, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 0c2a101214 06/15: Fix compilation of test file, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 2800920ae6 12/15: * hui-select.el: Fix a few warnings and improve some docstrings, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 10948143c9 13/15: (man-show): Fix miscompilation, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole b1db025326 01/15: * hload-path.el (hyperb:dir): Use `macroexp-file-name`, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole f519cae205 03/15: Try and avoid using `hyperb:stack-frame`, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 8894d83051 04/15: (kotl-mode:pre-self-insert-command): Use buffer-locally at top-level,
Stefan Monnier <=
- [elpa] scratch/hyperbole 963c6313d5 05/15: Get rid of `hyperb:stack-frame`, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 762fb43807 07/15: (kview:char-visible-p): Delete function, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 21746cca6a 08/15: * hact.el: Fix broken lexical-binding cookie, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 63a7e27454 11/15: * hycontrol.el (hycontrol-windows-mode-map): Don't autoload, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole e2d8b5e555 14/15: Fix a few minor miscompilations and warnings, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 7f44544723 10/15: hyperbole-autoloads.el: Remove needless definitions, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole 4bdcd214e3 15/15: * hyrolo.el: A few cosmetic tweaks, Stefan Monnier, 2023/05/29
- [elpa] scratch/hyperbole d290f19c21 09/15: * hyperbole.el: Preload `kotl-autoloads`, Stefan Monnier, 2023/05/29