emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org 6a2d84e501: ob-lilypond: Resolve FIXME


From: ELPA Syncer
Subject: [elpa] externals/org 6a2d84e501: ob-lilypond: Resolve FIXME
Date: Thu, 20 Jul 2023 03:59:22 -0400 (EDT)

branch: externals/org
commit 6a2d84e5018a35ec7ac95e0489ce25aab0cb6000
Author: Ihor Radchenko <yantar92@posteo.net>
Commit: Ihor Radchenko <yantar92@posteo.net>

    ob-lilypond: Resolve FIXME
    
    * lisp/ob-lilypond.el: Use `org-src-lang-modes' to inform Org babel
    about non-standard mode name instead of using `defalias'.
    * testing/lisp/test-ob-lilypond.el (ob-lilypond/check-lilypond-alias):
    Remove test.
---
 lisp/ob-lilypond.el              | 4 +---
 testing/lisp/test-ob-lilypond.el | 3 ---
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el
index 9693b89e23..a4fab00e04 100644
--- a/lisp/ob-lilypond.el
+++ b/lisp/ob-lilypond.el
@@ -40,10 +40,8 @@
 
 (declare-function org-fold-show-all "org-fold" (&optional types))
 
-;; FIXME: Doesn't this rather belong in lilypond-mode.el?
-(defalias 'lilypond-mode 'LilyPond-mode)
-
 (add-to-list 'org-babel-tangle-lang-exts '("LilyPond" . "ly"))
+(add-to-list 'org-src-lang-modes '("lilypond" . "LilyPond"))
 
 (defvar org-babel-default-header-args:lilypond '()
   "Default header arguments for lilypond code blocks.
diff --git a/testing/lisp/test-ob-lilypond.el b/testing/lisp/test-ob-lilypond.el
index 27e1675c9e..b829b8a10c 100644
--- a/testing/lisp/test-ob-lilypond.el
+++ b/testing/lisp/test-ob-lilypond.el
@@ -32,9 +32,6 @@
 (ert-deftest ob-lilypond/feature-provision ()
   (should (featurep 'ob-lilypond)))
 
-(ert-deftest ob-lilypond/check-lilypond-alias ()
-  (should (fboundp 'lilypond-mode)))
-
 (ert-deftest ob-lilypond/org-babel-tangle-lang-exts ()
   (let ((found nil)
         (list org-babel-tangle-lang-exts))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]