emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 70f40ab788 2/3: Remove wrong test for file completion


From: ELPA Syncer
Subject: [nongnu] elpa/helm 70f40ab788 2/3: Remove wrong test for file completion
Date: Fri, 11 Aug 2023 06:59:54 -0400 (EDT)

branch: elpa/helm
commit 70f40ab7887133756370bffb1f417b829971794e
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Remove wrong test for file completion
    
    This fix describe-face, customize-face etc.. not displaying color of
    faces in completion, this because the afix fn was never called due to
    wrong assumption of file completion.
---
 helm-mode.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/helm-mode.el b/helm-mode.el
index 3a7315a2bb..c85f0efa8d 100644
--- a/helm-mode.el
+++ b/helm-mode.el
@@ -2313,10 +2313,8 @@ Can be used for `completion-in-region-function' by 
advicing it with an
                                                 (string= input ""))
                                       " "))
                  (file-comp-p (or (eq (completion-metadata-get metadata 
'category) 'file)
-                                  (helm-guess-filename-at-point)
-                                  ;; Assume that when `afun' and `predicate' 
are null
-                                  ;; we are in filename completion.
-                                  (and (null afun) (null predicate))))
+                                  (eq (plist-get completion-extra-properties 
:category) 'file)
+                                  (helm-guess-filename-at-point)))
                  ;; `completion-all-completions' store the base-size in the 
last `cdr',
                  ;; so data looks like this: '(a b c d . 0) and (last data) == 
(d . 0).
                  base-size



reply via email to

[Prev in Thread] Current Thread [Next in Thread]