[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phpinspect 6e5e2e3a07 3/8: Exclude comments from eldoc
From: |
ELPA Syncer |
Subject: |
[elpa] externals/phpinspect 6e5e2e3a07 3/8: Exclude comments from eldoc statement |
Date: |
Mon, 14 Aug 2023 15:58:29 -0400 (EDT) |
branch: externals/phpinspect
commit 6e5e2e3a07c3658b1954486e60ac9e00423163f5
Author: Hugo Thunnissen <devel@hugot.nl>
Commit: Hugo Thunnissen <devel@hugot.nl>
Exclude comments from eldoc statement
---
phpinspect-eldoc.el | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/phpinspect-eldoc.el b/phpinspect-eldoc.el
index 45db02e34e..b60bb885d2 100644
--- a/phpinspect-eldoc.el
+++ b/phpinspect-eldoc.el
@@ -136,7 +136,8 @@ be implemented for return values of
`phpinspect-eld-strategy-execute'")
(while (and left-sibling
(not (phpinspect-statement-introduction-p
(phpinspect-meta-token left-sibling))))
- (push left-sibling statement)
+ (unless (phpinspect-comment-p (phpinspect-meta-token left-sibling))
+ (push left-sibling statement))
(setq left-sibling (phpinspect-meta-find-left-sibling left-sibling)))
(phpinspect--log "Eldoc statement is: %s" (mapcar #'phpinspect-meta-token
statement))
@@ -165,16 +166,15 @@ be implemented for return values of
`phpinspect-eld-strategy-execute'")
(setf (phpinspect--resolvecontext-subject rctx)
(mapcar #'phpinspect-meta-token (butlast statement 2)))
- (let* ((type-of-previous-statement
- (phpinspect-resolve-type-from-context rctx))
- (method-name-sym (phpinspect-intern-name (cadadr
(phpinspect-meta-token (car match-result)))))
- (class (phpinspect-project-get-class-create
- (phpinspect--resolvecontext-project rctx)
- type-of-previous-statement))
- (method (when class
- (if static
- (phpinspect--class-get-static-method class
method-name-sym)
- (phpinspect--class-get-method class
method-name-sym)))))
+ (when-let* ((type-of-previous-statement
+ (phpinspect-resolve-type-from-context rctx))
+ (method-name-sym (phpinspect-intern-name (cadadr
(phpinspect-meta-token (car match-result)))))
+ (class (phpinspect-project-get-class-create
+ (phpinspect--resolvecontext-project rctx)
+ type-of-previous-statement))
+ (method (if static
+ (phpinspect--class-get-static-method class
method-name-sym)
+ (phpinspect--class-get-method class
method-name-sym))))
(when method
(phpinspect-make-function-doc :fn method :arg-pos arg-pos))))
((setq match-result (phpinspect--match-sequence (last statement 2)
- [elpa] externals/phpinspect updated (7c76cbcc54 -> f1e4a5be7d), ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect 8b6dc2eb38 1/8: Catch composer json format errors and notify user, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect 71531b7996 5/8: Define free variables + use condition-case-unless-debug, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect f1e4a5be7d 8/8: Remove debug statement for company backend, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect 6e5e2e3a07 3/8: Exclude comments from eldoc statement,
ELPA Syncer <=
- [elpa] externals/phpinspect 2ff9919e44 4/8: Add debug statements + use condition-case-unless-debug for token indexation, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect 633b08809e 2/8: Only retrieve/update class when a name has been declared for it, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect f6cc199886 7/8: When debugging, forward worker errors to main thread, ELPA Syncer, 2023/08/14
- [elpa] externals/phpinspect f9f12590e8 6/8: Handle cases where declarations do not contain a name, ELPA Syncer, 2023/08/14