emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm da93e5c1f7 2/2: Fix bad completing-read default arg "


From: ELPA Syncer
Subject: [nongnu] elpa/helm da93e5c1f7 2/2: Fix bad completing-read default arg "nil"
Date: Sat, 19 Aug 2023 10:00:36 -0400 (EDT)

branch: elpa/helm
commit da93e5c1f7193fda629afcbe5bb539d92b64c9db
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Fix bad completing-read default arg "nil"
    
    Some functions like debug-on-entry use (symbol-name sym)
    without checking if sym is non nil, so the return value become
    "nil".
---
 helm-mode.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/helm-mode.el b/helm-mode.el
index f2b4a60a22..dc7f2a7f41 100644
--- a/helm-mode.el
+++ b/helm-mode.el
@@ -568,7 +568,10 @@ If COLLECTION is an `obarray', a TEST should be needed. 
See `obarray'."
                                 do (setq cands (delete d cands))
                                 when str collect str)
                        cands))
-              ((and (not (equal default ""))
+              ;; Some functions like debug-on-entry use (symbol-name sym)
+              ;; without checking if sym is non nil, so the return value become
+              ;; "nil". 
+              ((and (not (member default '("" "nil")))
                     (string= helm-pattern ""))
                (cons default (delete (helm-stringify default)
                                      cands)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]