emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/popper 8c50bb3254 062/102: Added TODO in delete-popup f


From: ELPA Syncer
Subject: [elpa] externals/popper 8c50bb3254 062/102: Added TODO in delete-popup for later
Date: Fri, 8 Sep 2023 15:58:54 -0400 (EDT)

branch: externals/popper
commit 8c50bb3254b3ac42a0abb05ea44eb636602a330c
Author: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Commit: Karthik Chikmagalur <karthikchikmagalur@gmail.com>

    Added TODO in delete-popup for later
---
 popper.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/popper.el b/popper.el
index 3897c27917..4daa43eb4b 100644
--- a/popper.el
+++ b/popper.el
@@ -434,9 +434,12 @@ a popup buffer to open."
   "Delete popup window WIN in a manner appropriate to its type."
   (when (window-valid-p win)
     (cond
-     ((window-parent win) (if (window-parameter win 'window-side)
-                             (delete-window win)
-                           (quit-window nil win)))
+     ((window-parent win)
+      ;; Kludge. Side windows and regular windows are handled differently. The
+      ;; latter is still somewhat broken. This is a bad idea.
+      (if (window-parameter win 'window-side)
+         (delete-window win)
+       (quit-window nil win)))
      ((frame-parent) (delete-frame))
      (t (quit-window nil win)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]