emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/org-contrib 862567c79e: * lisp/ob-stata.el: Fix compiler w


From: ELPA Syncer
Subject: [nongnu] elpa/org-contrib 862567c79e: * lisp/ob-stata.el: Fix compiler warnings
Date: Sat, 9 Sep 2023 07:00:20 -0400 (EDT)

branch: elpa/org-contrib
commit 862567c79e510182ea16390ed05a912af61532f4
Author: Ihor Radchenko <yantar92@posteo.net>
Commit: Ihor Radchenko <yantar92@posteo.net>

    * lisp/ob-stata.el: Fix compiler warnings
    
    (org-babel-expand-body:stata): Remove obsolete lambda call.
    (org-babel-variable-assignments:stata): Use `number-sequence' instead
    of `org-number-sequence'.
    (org-babel-stata-evaluate-external-process):
    (org-babel-stata-evaluate-session): Quote ' in the docstrings.
---
 lisp/ob-stata.el | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/lisp/ob-stata.el b/lisp/ob-stata.el
index 13f9e091a4..2b15e6fd77 100644
--- a/lisp/ob-stata.el
+++ b/lisp/ob-stata.el
@@ -85,12 +85,13 @@
         (or graphics-file (org-babel-stata-graphical-output-file params))))
     (mapconcat
      #'identity
-     ((lambda (inside)
-       (if graphics-file
-            inside
-         inside))
-      (append (org-babel-variable-assignments:stata params)
-             (list body))) "\n")))
+     (if graphics-file
+        (append (org-babel-variable-assignments:stata params)
+                (list body))
+       ;; FIXME: same value for both `if' branches.
+       (append (org-babel-variable-assignments:stata params)
+              (list body)))
+     "\n")))
 
 (defun org-babel-execute:stata (body params)
   "Execute a block of stata code.
@@ -152,7 +153,7 @@ This function is called by `org-babel-execute-src-block'."
               (cdr (nth i vars))
               (cdr (nth i (cdr (assq :colname-names params))))
               (cdr (nth i (cdr (assq :rowname-names params)))))))
-      (org-number-sequence 0 (1- (length vars)))))))
+      (number-sequence 0 (1- (length vars)))))))
 
 (defun org-babel-stata-quote-csv-field (s)
   "Quote field S for export to stata."
@@ -233,10 +234,10 @@ current code buffer."
      body result-type result-params column-names-p row-names-p)))
 
 (defun org-babel-stata-evaluate-external-process
-  (body result-type result-params column-names-p row-names-p)
+    (body result-type result-params column-names-p row-names-p)
   "Evaluate BODY in external stata process.
-If RESULT-TYPE equals 'output then return standard output as a
-string.  If RESULT-TYPE equals 'value then return the value of the
+If RESULT-TYPE equals \\='output then return standard output as a
+string.  If RESULT-TYPE equals \\='value then return the value of the
 last statement in BODY, as elisp."
   (cl-case result-type
     (value
@@ -255,10 +256,10 @@ last statement in BODY, as elisp."
     (output (org-babel-eval org-babel-stata-command body))))
 
 (defun org-babel-stata-evaluate-session
-  (session body result-type result-params column-names-p row-names-p)
+    (session body result-type result-params column-names-p row-names-p)
   "Evaluate BODY in SESSION.
-If RESULT-TYPE equals 'output then return standard output as a
-string.  If RESULT-TYPE equals 'value then return the value of the
+If RESULT-TYPE equals \\='output then return standard output as a
+string.  If RESULT-TYPE equals \\='value then return the value of the
 last statement in BODY, as elisp."
   (cl-case result-type
     (value



reply via email to

[Prev in Thread] Current Thread [Next in Thread]