emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/vertico 81bec39151: Update commentaries and docstrings


From: ELPA Syncer
Subject: [elpa] externals/vertico 81bec39151: Update commentaries and docstrings
Date: Tue, 12 Sep 2023 06:59:07 -0400 (EDT)

branch: externals/vertico
commit 81bec39151f0a2fc6cad541f2290b4ab6282e6e2
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Update commentaries and docstrings
---
 CHANGELOG.org                 |  3 ++-
 extensions/vertico-repeat.el  |  7 ++++---
 extensions/vertico-suspend.el | 17 ++++++-----------
 3 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.org b/CHANGELOG.org
index e87138bfa0..75e2cd4353 100644
--- a/CHANGELOG.org
+++ b/CHANGELOG.org
@@ -4,7 +4,8 @@
 
 * Development
 
-- =vertico-suspend=: New experimental extension.
+- =vertico-suspend=: New extension to suspend and resume the current Vertico
+  completion session.
 - =vertico-directory-enter=: Exit with input if prefix argument is given. 
Mirrors
   the behavior of =vertico-exit=.
 - =vertico-mouse-map=: New keymap.
diff --git a/extensions/vertico-repeat.el b/extensions/vertico-repeat.el
index 4418e059a7..cb4165cf4d 100644
--- a/extensions/vertico-repeat.el
+++ b/extensions/vertico-repeat.el
@@ -41,9 +41,10 @@
 ;; (keymap-global-set "M-R" #'vertico-repeat)
 ;; (add-hook 'minibuffer-setup-hook #'vertico-repeat-save)
 ;;
-;; See also the `vertico-suspend' extension which uses a different
-;; technique, relying on recursive minibuffers to suspend the current
-;; completion session temporarily while preserving the entire state.
+;; See also the related extension `vertico-suspend', which uses a
+;; different technique, relying on recursive minibuffers to suspend
+;; the current completion session temporarily while preserving the
+;; entire state.
 
 ;;; Code:
 
diff --git a/extensions/vertico-suspend.el b/extensions/vertico-suspend.el
index fc9fc4fc6b..8b1267dba0 100644
--- a/extensions/vertico-suspend.el
+++ b/extensions/vertico-suspend.el
@@ -37,24 +37,19 @@
 ;;
 ;; (keymap-global-set "M-S" #'vertico-suspend)
 ;;
-;; The extension is currently experimental and may get removed again.
-;; See also the `vertico-repeat' extension which uses a different
-;; technique, storing a completion session history.
+;; See also the related extension `vertico-repeat', which uses a
+;; different technique, storing a completion session history.
 ;;
-;; The extension has the following known problems:
+;; The extension has the following known issues:
 ;;
 ;; * `vertico-suspend' restores the window configuration when resuming
 ;;   and when `vertico-buffer' is used.  This can be seen as a
-;;   disturbance.  I think the behavior is not unexpected since
-;;   minibuffer exiting also changes the window configuration by
-;;   default.
+;;   disturbance, however minibuffer exiting also changes the window
+;;   configuration by default.
 ;;
 ;; * `echo-keystrokes' does not work in recursive minibuffers.  This
 ;;   issue cannot be fixed without modifying the C source of Emacs,
 ;;   since Emacs disables echo in recursive minibuffers.
-;;
-;; * The function `set-minibuffer-message' is advised.  Maybe a more
-;;   elegant solution can be found to handle echo area messages?
 
 ;;; Code:
 
@@ -110,7 +105,7 @@ or the latest completion session is restored."
     (user-error "No Vertico session to suspend or resume")))
 
 (defun vertico-suspend--message (&rest app)
-  "Show message in suspended minibuffer, otherwise apply APP."
+  "Apply APP in non-suspended minibuffers, otherwise bail out."
   (when-let ((win (active-minibuffer-window))
              ((not (buffer-local-value 'vertico-suspend--ov (window-buffer 
win)))))
     (apply app)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]