emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/cider 31a65a15bf: Don't require `cider-log` eagerly


From: ELPA Syncer
Subject: [nongnu] elpa/cider 31a65a15bf: Don't require `cider-log` eagerly
Date: Fri, 22 Sep 2023 01:00:16 -0400 (EDT)

branch: elpa/cider
commit 31a65a15bf1fec41267c90437eaa75e46f67857b
Author: vemv <vemv@users.noreply.github.com>
Commit: Bozhidar Batsov <bozhidar@batsov.dev>

    Don't require `cider-log` eagerly
    
    It adds a some startup performance overhead (as it has transitive 
dependencies),
    and most importantly, its https://github.com/magit/transient dep appears to 
have an issue under Emacs 29
    (I'm currently investigating it prior to reporting it).
---
 cider-log.el  | 1 +
 cider-mode.el | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/cider-log.el b/cider-log.el
index fbe0106b89..62b9034283 100644
--- a/cider-log.el
+++ b/cider-log.el
@@ -792,6 +792,7 @@ The KEYS are used to lookup the values and are joined by 
SEPARATOR."
   "Return the log event at point."
   (get-text-property (point) :cider-log-event))
 
+;;;###autoload (autoload 'cider-log-info "cider-log-info" "Show the Cider log 
current log buffer, framework, appender and consumer." t)
 (defun cider-log-info ()
   "Show the current log buffer, framework, appender and consumer."
   (interactive)
diff --git a/cider-mode.el b/cider-mode.el
index 94e3be2534..8403bbdddb 100644
--- a/cider-mode.el
+++ b/cider-mode.el
@@ -33,7 +33,6 @@
 
 (require 'clojure-mode)
 (require 'cider-eval)
-(require 'cider-log)
 (require 'cider-test) ; required only for the menu
 (require 'cider-eldoc)
 (require 'cider-resolve)
@@ -531,6 +530,7 @@ higher precedence."
     (define-key map (kbd "C-c C-? C-d") #'cider-xref-fn-deps-select)
     (define-key map (kbd "C-c C-q") #'cider-quit)
     (define-key map (kbd "C-c M-r") #'cider-restart)
+    ;; NOTE: all cider-log* vars are autoloaded. Please do not add a require.
     (define-key map (kbd "C-c M-l a") #'cider-log-appender)
     (define-key map (kbd "C-c M-l c") #'cider-log-consumer)
     (define-key map (kbd "C-c M-l e") #'cider-log-event)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]