[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/git-commit c5597033d8: magit-section-{pre, post}-command-h
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/git-commit c5597033d8: magit-section-{pre, post}-command-hook: Don't suppress in transient |
Date: |
Tue, 10 Oct 2023 07:00:44 -0400 (EDT) |
branch: elpa/git-commit
commit c5597033d8cde513d124d9054ec0ad5f04889c20
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
magit-section-{pre,post}-command-hook: Don't suppress in transient
In [1: 95b432530a], we started suppressing these functions when a
transient is active. The main concern of that commit are context-
menus, and its message makes no mention of why we did this for
transients.
I have now run into cases, where suppressing this is undesirable
(i.e., when a transient prefix binds movement suffixes or allows
non-suffixes).
1: 2022-03-25 95b432530a6b131e63bec7411ee768f1dee9f629
Do not set point when invoking context-menu
---
lisp/magit-section.el | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/lisp/magit-section.el b/lisp/magit-section.el
index b81ae9ce60..575a981dc9 100644
--- a/lisp/magit-section.el
+++ b/lisp/magit-section.el
@@ -1575,8 +1575,7 @@ evaluated its BODY. Admittedly that's a bit of a hack."
;;; Highlight
(defun magit-section-pre-command-hook ()
- (when (and (not (bound-and-true-p transient--prefix))
- (or magit--context-menu-buffer
+ (when (and (or magit--context-menu-buffer
magit--context-menu-section)
(not (eq (ignore-errors
(event-basic-type (aref (this-command-keys) 0)))
@@ -1593,12 +1592,11 @@ evaluated its BODY. Admittedly that's a bit of a hack."
(defun magit-section-post-command-hook ()
(cursor-sensor-move-to-tangible (selected-window))
- (unless (bound-and-true-p transient--prefix)
- (when (or magit--context-menu-buffer
- magit--context-menu-section)
- (magit-menu-highlight-point-section))
- (unless (memq this-command '(magit-refresh magit-refresh-all))
- (magit-section-update-highlight))))
+ (when (or magit--context-menu-buffer
+ magit--context-menu-section)
+ (magit-menu-highlight-point-section))
+ (unless (memq this-command '(magit-refresh magit-refresh-all))
+ (magit-section-update-highlight)))
(defun magit-section-deactivate-mark ()
(setq magit-section-highlight-force-update t))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [nongnu] elpa/git-commit c5597033d8: magit-section-{pre, post}-command-hook: Don't suppress in transient,
ELPA Syncer <=