emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/emms c9dce6b305 36/42: Fix tests


From: ELPA Syncer
Subject: [elpa] externals/emms c9dce6b305 36/42: Fix tests
Date: Wed, 1 Nov 2023 15:58:02 -0400 (EDT)

branch: externals/emms
commit c9dce6b3057440a745018fc9a1aa5030271516e0
Author: Petteri Hintsanen <petterih@iki.fi>
Commit: Petteri Hintsanen <petterih@iki.fi>

    Fix tests
    
    - Remove ert-x dependency; it's not that useful and requires
    compatibility code.
    
    - Require 'emms in emms-info-native-ogg-tests so that byte compilation
    works.
---
 test/emms-info-native-ogg-tests.el |  1 +
 test/emms-info-native-tests.el     | 13 ++++---------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/test/emms-info-native-ogg-tests.el 
b/test/emms-info-native-ogg-tests.el
index 62243e4247..681c0ada2a 100644
--- a/test/emms-info-native-ogg-tests.el
+++ b/test/emms-info-native-ogg-tests.el
@@ -23,6 +23,7 @@
 
 ;;; Code:
 
+(require 'emms)
 (require 'emms-info-native-ogg)
 (require 'ert)
 
diff --git a/test/emms-info-native-tests.el b/test/emms-info-native-tests.el
index fb28c60bb2..395897f855 100644
--- a/test/emms-info-native-tests.el
+++ b/test/emms-info-native-tests.el
@@ -30,15 +30,10 @@
 
 (require 'emms-info-native)
 (require 'ert)
-(require 'ert-x)
-
-(unless (fboundp 'ert-resource-file)
-  (defun ert-resource-file (file)
-    (concat "resources/" file)))
 
 (ert-deftest emms-info-native-test-mp3 ()
   (should (equal (emms-info-native--decode-info-fields
-                  (ert-resource-file "sine.mp3"))
+                  "resources/sine.mp3")
                  '(("year" . "2023")
                    ("album" . "Test Data ☺")
                    ("artist" . "EMMS project")
@@ -47,7 +42,7 @@
 
 (ert-deftest emms-info-native-test-ogg ()
   (should (equal (emms-info-native--decode-info-fields
-                  (ert-resource-file "sine.ogg"))
+                  "resources/sine.ogg")
                  '(("artist" . "EMMS project")
                    ("date" . "2023-09-02")
                    ("title" . "440 Hz sine wave")
@@ -56,7 +51,7 @@
 
 (ert-deftest emms-info-native-test-flac ()
   (should (equal (emms-info-native--decode-info-fields
-                  (ert-resource-file "sine.flac"))
+                  "resources/sine.flac")
                  '(("artist" . "EMMS project")
                    ("date" . "2023-09-02")
                    ("title" . "440 Hz sine wave")
@@ -65,7 +60,7 @@
 
 (ert-deftest emms-info-native-test-opus ()
   (should (equal (emms-info-native--decode-info-fields
-                  (ert-resource-file "sine.opus"))
+                  "resources/sine.opus")
                  '(("artist" . "EMMS project")
                    ("date" . "2023-09-02")
                    ("title" . "440 Hz sine wave")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]