emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/emms e1f2810f39 13/42: Use string instead of vector as


From: ELPA Syncer
Subject: [elpa] externals/emms e1f2810f39 13/42: Use string instead of vector as Ogg page payload type
Date: Wed, 1 Nov 2023 15:58:00 -0400 (EDT)

branch: externals/emms
commit e1f2810f392bbea787aa9ed7553482b7d71e5934
Author: Petteri Hintsanen <petterih@iki.fi>
Commit: Petteri Hintsanen <petterih@iki.fi>

    Use string instead of vector as Ogg page payload type
    
    Strings use much less memory than vectors.
---
 emms-info-ogg.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/emms-info-ogg.el b/emms-info-ogg.el
index ddec76b6fc..165cb8a1be 100644
--- a/emms-info-ogg.el
+++ b/emms-info-ogg.el
@@ -77,7 +77,7 @@ exhaustion in case of garbled or malicious inputs.")
     (page-checksum u32r)
     (page-segments u8)
     (segment-table vec (page-segments))
-    (payload vec (eval (seq-reduce #'+ last 0))))
+    (payload str (eval (seq-reduce #'+ last 0))))
   "Ogg page structure specification.")
 
 (defconst emms-info-ogg--magic-pattern
@@ -189,12 +189,12 @@ Only elementary streams are supported, that is, FILENAME 
should
 contain only a single logical stream.  Note that this assumption
 is not verified: with non-elementary streams packets from
 different streams will be mixed together without an error."
-  (let ((num-packets 0) (offset 0) (stream (vector)))
+  (let ((num-packets 0) (offset 0) (stream (string)))
     (while (< num-packets packets)
       (let ((page (emms-info-ogg--read-and-decode-page filename offset)))
         (cl-incf num-packets (or (plist-get page :num-packets) 0))
         (cl-incf offset (plist-get page :num-bytes))
-        (setq stream (vconcat stream (plist-get page :stream)))
+        (setq stream (concat stream (plist-get page :stream)))
         (when (> (length stream) emms-info-ogg--max-peek-size)
           (error "Ogg payload is too large"))))
     stream))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]