emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/emms f594f7edac 15/42: Use strings instead of vectors f


From: ELPA Syncer
Subject: [elpa] externals/emms f594f7edac 15/42: Use strings instead of vectors for passing data
Date: Wed, 1 Nov 2023 15:58:00 -0400 (EDT)

branch: externals/emms
commit f594f7edac44f126072ff5822dab1cba72e17b69
Author: Petteri Hintsanen <petterih@iki.fi>
Commit: Petteri Hintsanen <petterih@iki.fi>

    Use strings instead of vectors for passing data
---
 emms-info-flac.el            | 4 ++--
 test/emms-info-flac-tests.el | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/emms-info-flac.el b/emms-info-flac.el
index 743abe44bb..4c8b321902 100644
--- a/emms-info-flac.el
+++ b/emms-info-flac.el
@@ -144,11 +144,11 @@ info blocks.  Extract and return them in a list, if 
found."
           (when (= block-type 0)
             ;; Stream info block found, extract it.
             (funcall read-func offset end)
-            (setq stream-info-block (vconcat (buffer-string))))
+            (setq stream-info-block (buffer-string)))
           (when (= block-type 4)
             ;; Comment block found, extract it.
             (funcall read-func offset end)
-            (setq comment-block (vconcat (buffer-string))))
+            (setq comment-block (buffer-string)))
           (setq offset end)))
       (list comment-block stream-info-block))))
 
diff --git a/test/emms-info-flac-tests.el b/test/emms-info-flac-tests.el
index 3b40f1d1fb..e2af51cf21 100644
--- a/test/emms-info-flac-tests.el
+++ b/test/emms-info-flac-tests.el
@@ -47,7 +47,8 @@ for `emms-info-flac--decode-meta-blocks'."
                  #'emms-test-invalid-flac-block-type))
   (should (equal (emms-info-flac--decode-meta-blocks
                   #'emms-test-valid-flac-block)
-                 '([1 2 3 4] [10 11 12 13 14 15 16 17]))))
+                 (list (unibyte-string 1 2 3 4)
+                       (unibyte-string 10 11 12 13 14 15 16 17)))))
 
 (ert-deftest emms-flac-test-decode-duration ()
   ;; The corresponding sample metadata bytes are [10 196 66 240 1 8 36 0].



reply via email to

[Prev in Thread] Current Thread [Next in Thread]