emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dired-duplicates 94319f44f7 47/57: Improve checking par


From: ELPA Syncer
Subject: [elpa] externals/dired-duplicates 94319f44f7 47/57: Improve checking parameters and handling parameter errors
Date: Sat, 4 Nov 2023 06:58:30 -0400 (EDT)

branch: externals/dired-duplicates
commit 94319f44f716e9b4b0e0d4f6067c0e028dc0072b
Author: Harald Judt <h.judt@gmx.at>
Commit: Harald Judt <h.judt@gmx.at>

    Improve checking parameters and handling parameter errors
    
    Move list check out into the higher-level function. The lower level 
function is
    private and so one can expect it to receive proper values.
---
 dired-duplicates.el | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/dired-duplicates.el b/dired-duplicates.el
index 087cda8e93..b9fc64b015 100644
--- a/dired-duplicates.el
+++ b/dired-duplicates.el
@@ -131,9 +131,7 @@ duplicate files as values."
                             (if dired-duplicates-search-directories-recursively
                                 (directory-files-recursively d ".*")
                               (cl-remove-if #'file-directory-p 
(directory-files d t nil t))))
-                          (if (listp directories)
-                              directories
-                            (list directories))))
+                          directories))
            and same-size-table = (make-hash-table)
            and checksum-table = (make-hash-table :test 'equal)
            for f in files
@@ -214,15 +212,13 @@ The results will be shown in a Dired buffer."
                                                default-directory
                                                nil
                                                default-directory)))
-  (let ((default-directory "/")
-        (truncated-dirs (truncate-string-to-width
-                         (string-join (if (listp directories)
-                                          directories
-                                        (list directories))
-                                      ", ")
-                         40 0 nil t)))
+  (unless directories
+    (user-error "Specify one or more directories to search in"))
+  (let* ((directories (if (listp directories) directories (list directories)))
+         (truncated-dirs (truncate-string-to-width (string-join directories ", 
") 40 0 nil t)))
     (message "Finding duplicate files in %s..." truncated-dirs)
-    (if-let ((results (dired-duplicates--generate-grouped-results 
directories)))
+    (if-let ((default-directory "/")
+             (results (dired-duplicates--generate-grouped-results 
directories)))
         (progn
           (message "Finding duplicate files in %s completed." truncated-dirs)
           (dired (cons "/" (flatten-list results)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]