[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dired-duplicates 94319f44f7 47/57: Improve checking par
|
From: |
ELPA Syncer |
|
Subject: |
[elpa] externals/dired-duplicates 94319f44f7 47/57: Improve checking parameters and handling parameter errors |
|
Date: |
Sat, 4 Nov 2023 06:58:30 -0400 (EDT) |
branch: externals/dired-duplicates
commit 94319f44f716e9b4b0e0d4f6067c0e028dc0072b
Author: Harald Judt <h.judt@gmx.at>
Commit: Harald Judt <h.judt@gmx.at>
Improve checking parameters and handling parameter errors
Move list check out into the higher-level function. The lower level
function is
private and so one can expect it to receive proper values.
---
dired-duplicates.el | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/dired-duplicates.el b/dired-duplicates.el
index 087cda8e93..b9fc64b015 100644
--- a/dired-duplicates.el
+++ b/dired-duplicates.el
@@ -131,9 +131,7 @@ duplicate files as values."
(if dired-duplicates-search-directories-recursively
(directory-files-recursively d ".*")
(cl-remove-if #'file-directory-p
(directory-files d t nil t))))
- (if (listp directories)
- directories
- (list directories))))
+ directories))
and same-size-table = (make-hash-table)
and checksum-table = (make-hash-table :test 'equal)
for f in files
@@ -214,15 +212,13 @@ The results will be shown in a Dired buffer."
default-directory
nil
default-directory)))
- (let ((default-directory "/")
- (truncated-dirs (truncate-string-to-width
- (string-join (if (listp directories)
- directories
- (list directories))
- ", ")
- 40 0 nil t)))
+ (unless directories
+ (user-error "Specify one or more directories to search in"))
+ (let* ((directories (if (listp directories) directories (list directories)))
+ (truncated-dirs (truncate-string-to-width (string-join directories ",
") 40 0 nil t)))
(message "Finding duplicate files in %s..." truncated-dirs)
- (if-let ((results (dired-duplicates--generate-grouped-results
directories)))
+ (if-let ((default-directory "/")
+ (results (dired-duplicates--generate-grouped-results
directories)))
(progn
(message "Finding duplicate files in %s completed." truncated-dirs)
(dired (cons "/" (flatten-list results)))
- [elpa] externals/dired-duplicates 6508b208e2 30/57: Add option to search directories recursively or not, (continued)
- [elpa] externals/dired-duplicates 6508b208e2 30/57: Add option to search directories recursively or not, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 03ad95f3a9 31/57: Add README.org, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4cfe600a15 36/57: Use user-error instead of error in find-duplicates-checksum-file, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates b4a7b0a3e7 38/57: Lower required emacs version to 27.1, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 31c1aa8880 40/57: Rename all occurrences of find-duplicates to dired-duplicates, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 6df828caac 41/57: README.org: Add more detailed explanations, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 887560b192 42/57: Get rid of separator files, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4c17bcdcc0 43/57: Separate search results using empty lines, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 0a9a5d8b65 44/57: Make separating results optional again, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4664aed213 46/57: Fix truncating directories when calling dired-duplicates non-interactively, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 94319f44f7 47/57: Improve checking parameters and handling parameter errors,
ELPA Syncer <=
- [elpa] externals/dired-duplicates 3c16f56388 48/57: Install workarounds for Emacs Dired bug #57565, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates c6193334fd 50/57: Update copyright notice to point to the FSF, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates c1dbfc5bcd 53/57: Improve error handling of checksum program, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates b5a9eb1cc1 26/57: flymake: Fix warning about unused lexical variables, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4fde2fbfa7 33/57: Fix first lines of docstrings, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 94542206f7 49/57: Update GPL3 LICENSE file, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4cf9eeb365 54/57: Remove conditional checks that dolist does for free, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates ec0a89ca32 57/57: Remove commented line of code, ELPA Syncer, 2023/11/04
- [elpa] externals/dired-duplicates 4a18d41af4 56/57: Use use-local-map instead of setf current-local-map, ELPA Syncer, 2023/11/04