emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 89414fa8eb 1/4: Remove file completion fn in favor of


From: ELPA Syncer
Subject: [nongnu] elpa/helm 89414fa8eb 1/4: Remove file completion fn in favor of HFF
Date: Sat, 4 Nov 2023 15:59:57 -0400 (EDT)

branch: elpa/helm
commit 89414fa8eb77b8dd93f5b8c8da8e855b9a260a39
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Remove file completion fn in favor of HFF
---
 helm-elisp.el  | 20 +++-----------------
 helm-eshell.el |  2 +-
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/helm-elisp.el b/helm-elisp.el
index 0741597080..0f660f03a8 100644
--- a/helm-elisp.el
+++ b/helm-elisp.el
@@ -462,7 +462,7 @@ documentation when SYM name is the same for function and 
variable."
   "Preconfigured Helm to complete file name at point."
   (interactive)
   (require 'helm-mode)
-  (let* ((tap (or (thing-at-point 'filename) ""))
+  (let* ((tap (or (thing-at-point 'filename t) ""))
          beg
          (init (and tap
                     (or force
@@ -471,8 +471,7 @@ documentation when SYM name is the same for function and 
variable."
                           (search-backward tap (pos-bol) t)
                           (setq beg (point))
                           (looking-back "[^'`( ]" (1- (point)))))
-                    (expand-file-name
-                     (substring-no-properties tap))))
+                    (expand-file-name tap)))
          (end  (point))
          (helm-quit-if-no-candidate t)
          (helm-execute-action-at-once-if-one t)
@@ -484,6 +483,7 @@ documentation when SYM name is the same for function and 
variable."
       (delete-region beg end) (insert (if (string-match "^~" tap)
                                           (abbreviate-file-name completion)
                                         completion)))))
+(make-obsolete 'helm-complete-file-name-at-point 'helm-find-files "3.9.6")
 
 ;;;###autoload
 (defun helm-lisp-indent ()
@@ -495,20 +495,6 @@ documentation when SYM name is the same for function and 
variable."
                                tab-always-indent)))
     (indent-for-tab-command current-prefix-arg)))
 
-;;;###autoload
-(defun helm-lisp-completion-or-file-name-at-point ()
-  "Preconfigured Helm to complete Lisp symbol or filename at point.
-Filename completion happens if string start after or between a
-double quote."
-  (interactive)
-  (let* ((tap (thing-at-point 'filename)))
-    (if (and tap (save-excursion
-                   (end-of-line)
-                   (search-backward tap (pos-bol) t)
-                   (looking-back "[^'`( ]" (1- (point)))))
-        (helm-complete-file-name-at-point)
-      (helm-lisp-completion-at-point))))
-
 
 ;;; Apropos
 ;;
diff --git a/helm-eshell.el b/helm-eshell.el
index b85e5015f4..fae99c359a 100644
--- a/helm-eshell.el
+++ b/helm-eshell.el
@@ -290,7 +290,7 @@ at point."
       (delete-char -1) (setq del-dot t)
       (setq helm-ec-target (substring helm-ec-target 0 (1- (length 
helm-ec-target)))))
     (cond ((eq first ?\()
-           (helm-lisp-completion-or-file-name-at-point))
+           (helm-lisp-completion-at-point))
           ;; In eshell `pcomplete-parse-arguments' is called
           ;; with `pcomplete-parse-arguments-function'
           ;; locally bound to `eshell-complete-parse-arguments'



reply via email to

[Prev in Thread] Current Thread [Next in Thread]