[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 8d19849fa5 1/2: Note reason for FIXME in 'denote
|
From: |
ELPA Syncer |
|
Subject: |
[elpa] externals/denote 8d19849fa5 1/2: Note reason for FIXME in 'denote-file-prompt' |
|
Date: |
Tue, 7 Nov 2023 00:57:42 -0500 (EST) |
branch: externals/denote
commit 8d19849fa5b44c32eca2ee8e6b31478eb455cee2
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Note reason for FIXME in 'denote-file-prompt'
---
denote.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/denote.el b/denote.el
index 5796c69d6c..795964d481 100644
--- a/denote.el
+++ b/denote.el
@@ -940,6 +940,13 @@ the given regular expression."
(file (funcall project-read-file-name-function
;; FIXME 2023-10-15: Why do I get an empty history
at the prompt even
;; though it is given as an argument and it is not
empty?
+ ;;
+ ;; UPDATE 2023-11-07 05:11 +0200: The history
breaks because the
+ ;; function does a `string-prefix-p' for an
abbreviated file path. We
+ ;; could abbreviate the history items, though I am
not happy with this
+ ;; because it may have implications in other
places where we expect a
+ ;; full path. We could also make a copy of the
history and abbreviate
+ ;; that, but it seems expensive.
"Select note: " files nil 'denote--file-history)))
(let ((completion-ignore-case read-file-name-completion-ignore-case))
(add-to-history 'denote--file-history file)