emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 9a7eb0d9a3 09/41: transient--make-predicate-m


From: Jonas Bernoulli
Subject: [elpa] externals/transient 9a7eb0d9a3 09/41: transient--make-predicate-map: Use define-key exclusively
Date: Sun, 12 Nov 2023 20:04:07 -0500 (EST)

branch: externals/transient
commit 9a7eb0d9a346e861ff5c5609561de02cf25aa01a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    transient--make-predicate-map: Use define-key exclusively
    
    1. This is not a proper key binding, so "use `keymap-set' family
       of functions for consistency and to make it easier to find all
       keybindings" does not apply; and by using a `define-key', we
       signal that there is something special about this binding.
    
    2. For the other bindings established in this function, we already
       use `define-key', and we want local consistency.
---
 lisp/transient.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index d0cdd8ae01..a3b45ddfc0 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1760,7 +1760,7 @@ of the corresponding object."
     (set-keymap-parent map transient-predicate-map)
     (when (memq (oref transient--prefix transient-non-suffix)
                 '(nil transient--do-warn transient--do-noop))
-      (keymap-set map "<handle-switch-frame>" #'transient--do-suspend))
+      (define-key map [handle-switch-frame] #'transient--do-suspend))
     (dolist (obj transient--suffixes)
       (let* ((cmd (oref obj command))
              (sub-prefix (and (symbolp cmd) (get cmd 'transient--prefix) t)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]