emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 6caf8755eb 2/2: Fix: Ensure signature is sluggif


From: ELPA Syncer
Subject: [elpa] externals/denote 6caf8755eb 2/2: Fix: Ensure signature is sluggified correctly when renaming
Date: Sat, 18 Nov 2023 03:57:55 -0500 (EST)

branch: externals/denote
commit 6caf8755ebbd898aef8a2c2728014ae897550e1c
Author: Vedang Manerikar <ved.manerikar@gmail.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Fix: Ensure signature is sluggified correctly when renaming
    
    Based on the bug found in the previous commit, I looked at all the
    call-sites for `denote-sluggify-signature` and
    `denote-retrieve-filename-signature` and found two other places:
    
    1. `denote-rename-file`: Add check to ensure signature exists when
       trying to sluggify it.
    
    2. `denote-rename-file-using-front-matter`: Sluggify the signature
       before creating the new file-name.
---
 denote.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/denote.el b/denote.el
index 9d8e006f73..c6137f6324 100644
--- a/denote.el
+++ b/denote.el
@@ -2429,7 +2429,7 @@ place."
          (title (or title (denote--retrieve-title-or-filename file file-type)))
          (keywords (or keywords (denote-retrieve-keywords-value file 
file-type)))
          (signature (or signature (denote-retrieve-filename-signature file)))
-         (new-name (denote-format-file-name dir id keywords (denote-sluggify 
title 'title) extension (denote-sluggify-signature signature)))
+         (new-name (denote-format-file-name dir id keywords (denote-sluggify 
title 'title) extension (when signature (denote-sluggify-signature signature))))
          (max-mini-window-height denote-rename-max-mini-window-height))
     (when (or denote-rename-no-confirm (denote-rename-file-prompt file 
new-name))
       (denote-rename-file-and-buffer file new-name)
@@ -2573,7 +2573,7 @@ does internally."
              (signature (denote-retrieve-filename-signature file))
              (extension (denote-get-file-extension file))
              (dir (file-name-directory file))
-             (new-name (denote-format-file-name dir id keywords 
sluggified-title extension signature)))
+             (new-name (denote-format-file-name dir id keywords 
sluggified-title extension (when signature (denote-sluggify-signature 
signature)))))
         (when (or auto-confirm
                   (denote-rename-file-prompt file new-name))
           (denote-rename-file-and-buffer file new-name)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]