emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 47d3f01d9f 17/26: Fix/improve some faces


From: Jonas Bernoulli
Subject: [elpa] externals/transient 47d3f01d9f 17/26: Fix/improve some faces
Date: Sun, 26 Nov 2023 19:42:07 -0500 (EST)

branch: externals/transient
commit 47d3f01d9f59f50862ae5bfe99e0938744156704
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Fix/improve some faces
    
    Derive `transient-argument' from `font-lock-string-face' instead of
    `font-lock-warning-face'.  Enabling an argument doesn't warrant a
    warning.  `transient-value' also derives from `font-lock-string-face'
    and it makes sense for these two to look the same.
    
    Derive `transient-active-infix' from `highlight' instead of
    `secondary-selection'.  That looks better with the light default
    theme.  With the dark default theme both look okay.
    
    The goal of `transient-unreachable-key' is to dim the key, which we
    hope to achieve by inheriting from `shadow', but for that to work,
    that face must take precedence, which means it must come first in
    the list of inherited faces.
---
 lisp/transient.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index 56841f6783..6d46d5809e 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -442,7 +442,7 @@ give you as many additional suffixes as you hoped.)"
   "Face used for headings."
   :group 'transient-faces)
 
-(defface transient-argument '((t :inherit font-lock-warning-face))
+(defface transient-argument '((t :inherit font-lock-string-face :weight bold))
   "Face used for enabled arguments."
   :group 'transient-faces)
 
@@ -450,7 +450,7 @@ give you as many additional suffixes as you hoped.)"
   "Face used for inactive arguments."
   :group 'transient-faces)
 
-(defface transient-value '((t :inherit font-lock-string-face))
+(defface transient-value '((t :inherit font-lock-string-face :weight bold))
   "Face used for values."
   :group 'transient-faces)
 
@@ -466,7 +466,7 @@ give you as many additional suffixes as you hoped.)"
   "Face used for suffixes that are inapt at this time."
   :group 'transient-faces)
 
-(defface transient-active-infix '((t :inherit secondary-selection))
+(defface transient-active-infix '((t :inherit highlight))
   "Face used for the infix for which the value is being read."
   :group 'transient-faces)
 
@@ -497,7 +497,7 @@ character used to separate possible values from each other."
   "Face used for keys."
   :group 'transient-faces)
 
-(defface transient-unreachable-key '((t :inherit (transient-key shadow)))
+(defface transient-unreachable-key '((t :inherit (shadow transient-key)))
   "Face used for keys unreachable from the current prefix sequence."
   :group 'transient-faces)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]