[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 47d3f01d9f 17/26: Fix/improve some faces
|
From: |
Jonas Bernoulli |
|
Subject: |
[elpa] externals/transient 47d3f01d9f 17/26: Fix/improve some faces |
|
Date: |
Sun, 26 Nov 2023 19:42:07 -0500 (EST) |
branch: externals/transient
commit 47d3f01d9f59f50862ae5bfe99e0938744156704
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
Fix/improve some faces
Derive `transient-argument' from `font-lock-string-face' instead of
`font-lock-warning-face'. Enabling an argument doesn't warrant a
warning. `transient-value' also derives from `font-lock-string-face'
and it makes sense for these two to look the same.
Derive `transient-active-infix' from `highlight' instead of
`secondary-selection'. That looks better with the light default
theme. With the dark default theme both look okay.
The goal of `transient-unreachable-key' is to dim the key, which we
hope to achieve by inheriting from `shadow', but for that to work,
that face must take precedence, which means it must come first in
the list of inherited faces.
---
lisp/transient.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 56841f6783..6d46d5809e 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -442,7 +442,7 @@ give you as many additional suffixes as you hoped.)"
"Face used for headings."
:group 'transient-faces)
-(defface transient-argument '((t :inherit font-lock-warning-face))
+(defface transient-argument '((t :inherit font-lock-string-face :weight bold))
"Face used for enabled arguments."
:group 'transient-faces)
@@ -450,7 +450,7 @@ give you as many additional suffixes as you hoped.)"
"Face used for inactive arguments."
:group 'transient-faces)
-(defface transient-value '((t :inherit font-lock-string-face))
+(defface transient-value '((t :inherit font-lock-string-face :weight bold))
"Face used for values."
:group 'transient-faces)
@@ -466,7 +466,7 @@ give you as many additional suffixes as you hoped.)"
"Face used for suffixes that are inapt at this time."
:group 'transient-faces)
-(defface transient-active-infix '((t :inherit secondary-selection))
+(defface transient-active-infix '((t :inherit highlight))
"Face used for the infix for which the value is being read."
:group 'transient-faces)
@@ -497,7 +497,7 @@ character used to separate possible values from each other."
"Face used for keys."
:group 'transient-faces)
-(defface transient-unreachable-key '((t :inherit (transient-key shadow)))
+(defface transient-unreachable-key '((t :inherit (shadow transient-key)))
"Face used for keys unreachable from the current prefix sequence."
:group 'transient-faces)
- [elpa] externals/transient f23f51e24e 07/26: Rename transient--{do => call}-pre-command, (continued)
- [elpa] externals/transient f23f51e24e 07/26: Rename transient--{do => call}-pre-command, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 37307c1b8c 05/26: transient-prefix-object: New function, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 4c1cda9984 08/26: Rename transient-get-{predicate-for => pre-command}, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient f4b4dd42b9 14/26: Add transient--do-leave's missing color setting, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 0509c90e53 11/26: transient--key-face: New function, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 05754d1576 13/26: Rearrange pre-command color settings, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 98d8cf8016 15/26: Fix transient--do-quit-one's color setting, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 9c00fae158 10/26: transient--add-face: Move definition, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient b1951a87b5 09/26: transient--resolve-pre-command: Optionally resolve boolean as well, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 9a21467706 12/26: transient--separator-line: New function, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 47d3f01d9f 17/26: Fix/improve some faces,
Jonas Bernoulli <=
- [elpa] externals/transient ad7a098349 16/26: Rearrange face definitions, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient c8a9ac5124 18/26: Simplify how colors are used to indicate transient behavior, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 9f3afe94a9 19/26: transient-format(around:suffix): Reformat docstring, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 48a1aa2bea 24/26: transient-highlight-mismatched-keys: Fix docstring typos, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 46813a03f6 23/26: In support of the lovely pcase, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 307695d2df 21/26: transient-format-description(around:suffix): Combine faces, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 7f0215c4df 22/26: transient-format-value(option, value): Use argument faces, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient d834f76492 20/26: transient-format(around:suffix): Don't attempt to highlight full line, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient 71d16d86f1 25/26: Improve looks of debugging faces, Jonas Bernoulli, 2023/11/26
- [elpa] externals/transient af6eb31054 26/26: transient-format: Only highlight infix if minibuffer is used, Jonas Bernoulli, 2023/11/26