emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/hyperdrive dae287e1aa 012/102: Comment: Add transient todo


From: ELPA Syncer
Subject: [nongnu] elpa/hyperdrive dae287e1aa 012/102: Comment: Add transient todos
Date: Wed, 29 Nov 2023 04:00:46 -0500 (EST)

branch: elpa/hyperdrive
commit dae287e1aae7283755b9fc75394362804f711da4
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Comment: Add transient todos
---
 hyperdrive-menu.el   | 6 ++++++
 hyperdrive-mirror.el | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/hyperdrive-menu.el b/hyperdrive-menu.el
index 2d157752a4..a85073a4a1 100644
--- a/hyperdrive-menu.el
+++ b/hyperdrive-menu.el
@@ -230,6 +230,12 @@
   "Show menu for HYPERDRIVE."
   :refresh-suffixes t
   ["Hyperdrive"
+   ;; TODO(transient): Maybe support shared predicates like
+   ;; so, and then ":if entryp" to avoid duplication below.
+   ;; :predicates ((entryp ,(lambda () (hyperdrive-seed 
(hyperdrive-menu--entry)))))
+   ;; TODO(transient): Support subgroups in a column group,
+   ;; making the below "" "Upload" unnecessary.
+   ;; TODO(transient): Implement :inapt-if* for groups.
    :pad-keys t
    ("d" hyperdrive-menu-describe-hyperdrive)
    (:info (lambda () (concat "Public key: " (hyperdrive--format-host 
(hyperdrive-menu--entry) :format 'public-key))))
diff --git a/hyperdrive-mirror.el b/hyperdrive-mirror.el
index b1a4b7a9a2..3daa8e04f0 100644
--- a/hyperdrive-mirror.el
+++ b/hyperdrive-mirror.el
@@ -352,6 +352,8 @@ grouping keys, as in `hyperdrive-mirror-default-keys'."
              (lambda () (read--expression "Lambda: " "(lambda (filename) )")))
             ("Named function"   .
              (lambda () (completing-read "Named function: " obarray 
#'functionp t)))))
+         ;; TODO(transient): Implement returning values from prefixes,
+         ;; allowing us to use a sub-prefix here instead of completing-read.
          (reader (completing-read "Predicate type: " readers nil t))
          (reader (alist-get reader readers nil nil #'equal)))
     (and reader (funcall reader))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]