emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/hyperdrive 285692b095 08/31: Chore: Consistently use setf


From: ELPA Syncer
Subject: [nongnu] elpa/hyperdrive 285692b095 08/31: Chore: Consistently use setf even if setq would work
Date: Fri, 1 Dec 2023 01:00:38 -0500 (EST)

branch: elpa/hyperdrive
commit 285692b0952bd4c25101794c2be5f35c68c3ac14
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Joseph Turner <joseph@ushin.org>

    Chore: Consistently use setf even if setq would work
    
    We already did so *almost* consistently.
---
 hyperdrive-describe.el |  2 +-
 hyperdrive-lib.el      | 10 +++++-----
 hyperdrive-mirror.el   |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/hyperdrive-describe.el b/hyperdrive-describe.el
index eb5f4fe100..2cae15dd18 100644
--- a/hyperdrive-describe.el
+++ b/hyperdrive-describe.el
@@ -78,7 +78,7 @@ Universal prefix argument \\[universal-argument] forces
                        (org-table-align)
                        (buffer-string))
                    "[none]")))))
-    (setq buffer-read-only t)
+    (setf buffer-read-only t)
     (pop-to-buffer (current-buffer))))
 
 ;;;; Mode
diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el
index 72d27cfa9a..5bee7dfbd4 100644
--- a/hyperdrive-lib.el
+++ b/hyperdrive-lib.el
@@ -1324,7 +1324,7 @@ with `hyperdrive-handler-default'."
           ;; for remapped keybindings for, e.g., `h/up'.
           (setq-local h/current-entry entry)
           (h/mode)
-          (setq buffer (current-buffer)))
+          (setf buffer (current-buffer)))
         (set-buffer buffer)
         (when then
           (funcall then)))
@@ -1582,14 +1582,14 @@ function is a convenience wrapper used by 
`describe-package-1'."
        (while (consp tree)
          (let ((newcar (car tree)))
            (if (or (consp (car tree)) (and vecp (or (vectorp (car tree)) 
(recordp (car tree)))))
-               (setq newcar (h/copy-tree (car tree) vecp)))
+               (setf newcar (h/copy-tree (car tree) vecp)))
            (push newcar result))
-         (setq tree (cdr tree)))
+         (setf tree (cdr tree)))
        (nconc (nreverse result)
                (if (and vecp (or (vectorp tree) (recordp tree))) (h/copy-tree 
tree vecp) tree)))
     (if (and vecp (or (vectorp tree) (recordp tree)))
-       (let ((i (length (setq tree (copy-sequence tree)))))
-         (while (>= (setq i (1- i)) 0)
+       (let ((i (length (setf tree (copy-sequence tree)))))
+         (while (>= (setf i (1- i)) 0)
            (aset tree i (h/copy-tree (aref tree i) vecp)))
          tree)
       tree)))
diff --git a/hyperdrive-mirror.el b/hyperdrive-mirror.el
index 59b9369c54..f4635e7a80 100644
--- a/hyperdrive-mirror.el
+++ b/hyperdrive-mirror.el
@@ -389,7 +389,7 @@ Sets `hyperdrive-mirror-visibility-cache' to the value of
   :group 'hyperdrive
   :interactive nil
   ;; TODO: When possible, use vtable.el (currently only available in Emacs 
>=29) (or maybe taxy-magit-section)
-  (setq revert-buffer-function #'h/mirror-revert-buffer))
+  (setf revert-buffer-function #'h/mirror-revert-buffer))
 
 ;;;; Footer
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]