emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ement 64424c11bc: Change: (ement-room--format-reactions


From: ELPA Syncer
Subject: [elpa] externals/ement 64424c11bc: Change: (ement-room--format-reactions) Show name if only one sender
Date: Tue, 9 Jan 2024 00:57:45 -0500 (EST)

branch: externals/ement
commit 64424c11bc4ec7ab6cba00df4fb3d53ed9a93939
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Change: (ement-room--format-reactions) Show name if only one sender
---
 README.org    |  1 +
 ement-room.el | 13 ++++++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/README.org b/README.org
index 60064396b1..3ee68bcfd6 100644
--- a/README.org
+++ b/README.org
@@ -299,6 +299,7 @@ Ement.el doesn't support encrypted rooms natively, but it 
can be used transparen
 
 + Customization group ~ement-room-list~.
 + Option ~ement-room-list-space-prefix~ is applied to space names in the room 
list (e.g. set to empty string for cleaner appearance).
++ Reactions sent by only one user are displayed with the user's name (so it's 
not necessary to check the tooltip).
 
 *Changes*
 
diff --git a/ement-room.el b/ement-room.el
index 04ed116aa1..81f2e5b4a2 100644
--- a/ement-room.el
+++ b/ement-room.el
@@ -943,8 +943,8 @@ spec) without requiring all events to use the same margin 
width."
 
 (ement-room-define-event-formatter ?r
   "Reactions."
-  (ignore room session)
-  (ement-room--format-reactions event))
+  (ignore session)
+  (ement-room--format-reactions event room))
 
 (ement-room-define-event-formatter ?t
   "Timestamp."
@@ -3349,14 +3349,17 @@ Formats according to `ement-room-message-format-spec', 
which see."
           (propertize " "
                       'display ement-room-event-separator-display-property)))
 
-(defun ement-room--format-reactions (event)
-  "Return formatted reactions to EVENT."
+(defun ement-room--format-reactions (event room)
+  "Return formatted reactions to EVENT in ROOM."
   ;; TODO: Like other events, pop to a buffer showing the raw reaction events 
when a key is pressed.
   (if-let ((reactions (map-elt (ement-event-local event) 'reactions)))
       (cl-labels ((format-reaction (ks)
                     (pcase-let* ((`(,key . ,senders) ks)
                                  (key (propertize key 'face 
'ement-room-reactions-key))
-                                 (count (propertize (format " (%s)" (length 
senders))
+                                 (count (propertize (format " (%s)"
+                                                            (if (length= 
senders 1)
+                                                                
(ement--user-displayname-in room (car senders))
+                                                              (length 
senders)))
                                                     'face 
'ement-room-reactions))
                                  (string
                                   (propertize (concat key count)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]