emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/emacsql 3ec2c96e58 02/11: emacsql-log-buffer: Deprecate th


From: ELPA Syncer
Subject: [nongnu] elpa/emacsql 3ec2c96e58 02/11: emacsql-log-buffer: Deprecate this accessor for log-buffer slot
Date: Fri, 19 Jan 2024 19:00:24 -0500 (EST)

branch: elpa/emacsql
commit 3ec2c96e58df39e955531333d6f30fc2332d7cd4
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    emacsql-log-buffer: Deprecate this accessor for log-buffer slot
    
    We don't provide accessors for other slots either.
---
 emacsql.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/emacsql.el b/emacsql.el
index bd8bc0d24b..cfa8bb4dd3 100644
--- a/emacsql.el
+++ b/emacsql.el
@@ -104,6 +104,9 @@ may return `process', `user-ptr' or `sqlite' for this 
value.")
   "A connection to a SQL database."
   :abstract t)
 
+(make-obsolete 'emacsql-log-buffer "use (oref obj log-buffer) instead."
+               "EmacSQL 4.0.0")
+
 (cl-defgeneric emacsql-close (connection)
   "Close CONNECTION and free all resources.")
 
@@ -127,14 +130,13 @@ SQL expression.")
 
 (cl-defmethod emacsql-enable-debugging ((connection emacsql-connection))
   "Enable debugging on CONNECTION."
-  (unless (buffer-live-p (emacsql-log-buffer connection))
-    (setf (emacsql-log-buffer connection)
-          (generate-new-buffer " *emacsql-log*"))))
+  (unless (buffer-live-p (oref connection log-buffer))
+    (oset connection log-buffer (generate-new-buffer " *emacsql-log*"))))
 
 (cl-defmethod emacsql-log ((connection emacsql-connection) message)
   "Log MESSAGE into CONNECTION's log.
 MESSAGE should not have a newline on the end."
-  (let ((buffer (emacsql-log-buffer connection)))
+  (let ((buffer (oref connection log-buffer)))
     (when buffer
       (unless (buffer-live-p buffer)
         (setq buffer (emacsql-enable-debugging connection)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]