emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/emacsql 5aba772e56: Remove emacsql-log-buffer accessor for


From: ELPA Syncer
Subject: [nongnu] elpa/emacsql 5aba772e56: Remove emacsql-log-buffer accessor for good
Date: Wed, 24 Jan 2024 12:59:50 -0500 (EST)

branch: elpa/emacsql
commit 5aba772e562f0b22e36e34c9b4c256ffe439654c
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Remove emacsql-log-buffer accessor for good
    
    Deprecating the `emacsql-log-buffer' accessor wasn't graceful to begin
    with ([1: 3ec2c96], [2: f58cdd1]) and now (#119) we have learned that
    it also causes issues.  Instead remove it outright and be done with it.
    
    1: 2024-01-20 3ec2c96e58df39e955531333d6f30fc2332d7cd4
       emacsql-log-buffer: Deprecate this accessor for log-buffer slot
    
    2: 2024-01-21 f58cdd1ebe892b3c5f79096e9e458133e989449f
       emacsql-log-buffer: Also deprecate as generalized variable
    
    Closes #119.
---
 emacsql.el | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/emacsql.el b/emacsql.el
index 9ee771237e..007b577352 100644
--- a/emacsql.el
+++ b/emacsql.el
@@ -103,18 +103,6 @@ may return `process', `user-ptr' or `sqlite' for this 
value.")
   "A connection to a SQL database."
   :abstract t)
 
-(cl-defmethod (setf emacsql-log-buffer) (value (obj emacsql-connection))
-  (oset obj log-buffer value))
-(make-obsolete-generalized-variable 'emacsql-log-buffer
-                                    "use (oset obj log-buffer val) instead."
-                                    "EmacsSQL 4.0.0")
-(with-suppressed-warnings ((obsolete emacsql-log-buffer))
-  (cl-defmethod emacsql-log-buffer ((obj emacsql-connection)) "\
-Retrieve the slot `log-buffer' from an object of class `emacsql-connection'."
-    (oref obj log-buffer)))
-(make-obsolete 'emacsql-log-buffer "use (oref obj log-buffer) instead."
-               "EmacSQL 4.0.0")
-
 (cl-defgeneric emacsql-close (connection)
   "Close CONNECTION and free all resources.")
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]