emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 984c3feb24 2/6: Make denote-rename-buffer do not


From: ELPA Syncer
Subject: [elpa] externals/denote 984c3feb24 2/6: Make denote-rename-buffer do nothing if there is no underlying file
Date: Thu, 25 Jan 2024 00:57:44 -0500 (EST)

branch: externals/denote
commit 984c3feb24907a24ee59103bed7fc5a87145dbbb
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Make denote-rename-buffer do nothing if there is no underlying file
    
    If the buffer-file-name is nil, then we do not want to proceed because
    'denote-file-has-identifier-p' will return an error.
    
    This should fix the issue with epub files opened with nov.el, as
    reported by arsaber101 in issue 229:
    <https://github.com/protesilaos/denote/issues/229>.
---
 README.org              | 4 ++--
 denote-rename-buffer.el | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/README.org b/README.org
index 1117d7603a..2db6b11c6b 100644
--- a/README.org
+++ b/README.org
@@ -4966,8 +4966,8 @@ Denote is meant to be a collective effort.  Every bit of 
help matters.
   Fargas, Matthew Lemon, Noboru Ota (nobiot), Norwid Behrnd, Peter
   Prevos, Philip Kaludercic, Quiliro Ordóñez, Stefan Monnier, Stefan
   Thesing, Thibaut Benjamin, Tomasz Hołubowicz, Vedang Manerikar,
-  Wesley Harvey, ezchi, leinfink (Henrik), mentalisttraceur,
-  relict007.
+  Wesley Harvey, arsaber101, ezchi, leinfink (Henrik),
+  mentalisttraceur, relict007.
 
 + Ideas and/or user feedback :: Abin Simon, Aditya Yadav, Alan
   Schmitt, Aleksandr Vityazev, Alfredo Borrás, Ashton Wiersdorf,
diff --git a/denote-rename-buffer.el b/denote-rename-buffer.el
index c4324290d4..791b384e46 100644
--- a/denote-rename-buffer.el
+++ b/denote-rename-buffer.el
@@ -106,7 +106,8 @@ buffer will be used, if available."
 The symbol of this function is the default value of the user
 option `denote-rename-buffer-function' and is thus used by the
 `denote-rename-buffer-mode'."
-  (when-let (((denote-file-has-identifier-p (buffer-file-name buffer)))
+  (when-let ((file (buffer-file-name buffer))
+             ((denote-file-has-identifier-p file))
              (new-name (denote-rename-buffer--format (or buffer 
(current-buffer))))
              ((not (string-blank-p new-name))))
     (rename-buffer new-name :unique)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]