emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals-release/activities 31d563422f 030/103: Fix, tidy


From: ELPA Syncer
Subject: [elpa] externals-release/activities 31d563422f 030/103: Fix, tidy
Date: Tue, 30 Jan 2024 03:57:48 -0500 (EST)

branch: externals-release/activities
commit 31d563422f2e890bbf5177c3c2a63ed92e4a6e26
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Fix, tidy
---
 activity.el | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/activity.el b/activity.el
index 2f6e5fe6f6..f265bfb3bd 100644
--- a/activity.el
+++ b/activity.el
@@ -447,11 +447,7 @@ activity's name is NAME."
                              ((map parameters ('buffer 
`(,buffer-or-buffer-name . ,_buffer-attrs))) attrs))
                   (setf (map-elt parameters 'activity-buffer)
                         ;; HACK: Set buffer props parameter (maybe not the 
"right" place).
-                        (activity--serialize (get-buffer (car (map-elt attrs 
'buffer))))
-                        ;; HACK: Replace unserializable buffer (though 
`window-state-get'
-                        ;; should be filtering that out...).  NOTE: We must 
include the
-                        ;; "buffr-attrs" as-is.
-                        (car (map-elt attrs 'buffer)) (buffer-name (get-buffer 
buffer-or-buffer-name)))
+                        (activity--serialize (get-buffer (car (map-elt attrs 
'buffer)))))
                   (pcase-dolist (`(,parameter . ,(map serialize))
                                  activity-window-parameters-translators)
                     (when (map-elt parameters parameter)
@@ -466,7 +462,9 @@ activity's name is NAME."
   (setf window-persistent-parameters (copy-sequence 
activity-window-persistent-parameters))
   (pcase-let* ((window-persistent-parameters (append 
activity-window-persistent-parameters
                                                      
window-persistent-parameters))
-               (state (activity--bufferize-window-state state)))
+               (state
+                ;; NOTE: We copy the state so as not to mutate the one in 
storage.
+                (activity--bufferize-window-state (copy-sequence state))))
     ;; HACK: Since `bookmark--jump-via' insists on calling a buffer-display
     ;; function after handling the bookmark, we use an immediate timer to
     ;; set the window configuration.
@@ -489,7 +487,6 @@ activity's name is NAME."
                              ((map activity-buffer) parameters)
                              (`(,_buffer-name . ,buffer-attrs) buffer)
                              (new-buffer (activity--deserialize 
activity-buffer)))
-                  (activity-debug activity-buffer new-buffer)
                   (setf (map-elt attrs 'buffer) (cons new-buffer buffer-attrs))
                   (cons 'leaf attrs)))
               (translate-leaf (leaf)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]