emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals-release/activities 09b5d7f5f3 041/103: Remove: (activit


From: ELPA Syncer
Subject: [elpa] externals-release/activities 09b5d7f5f3 041/103: Remove: (activity-major-mode-alist)
Date: Tue, 30 Jan 2024 03:57:49 -0500 (EST)

branch: externals-release/activities
commit 09b5d7f5f39f8f3232c2365dd6e60e909cf9b2dc
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Remove: (activity-major-mode-alist)
    
    Let's avoid having this kind of hacky workaround.  Just get major
    modes to implement proper bookmark support and solve the problem at
    the right place.
---
 activity.el | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/activity.el b/activity.el
index e0e60b73f6..e264fab880 100644
--- a/activity.el
+++ b/activity.el
@@ -578,25 +578,10 @@ activity's name is NAME."
                               (format "Error while opening bookmark: ERROR:%S  
RECORD:%S" err struct))))
       (current-buffer))))
 
-(defcustom activity-major-mode-alist
-  (list (cons 'org-mode
-              (list (cons 'make-record-fn #'activity--org-mode-buffer-url)
-                    (cons 'open-record-fn #'activity-follow-url-org-mode))))
-  "Alist mapping major modes to the appropriate Activity functions."
-  :type '(alist :key-type symbol
-                :value-type (set (cons (const make-record-fn)
-                                       (function :tag "Make-record function"))
-                                 (cons (const open-record-fn)
-                                       (function :tag "Follow-record 
function")))))
-
 (defun activity--filename-buffer (activity-buffer)
   "Return buffer for ACTIVITY-BUFFER having `filename' set."
-  (pcase-let* (((cl-struct activity-buffer filename) activity-buffer)
-               (buffer (find-file-noselect filename))
-               (major-mode (buffer-local-value 'major-mode buffer))
-               (follow-fn (map-nested-elt activity-major-mode-alist (list 
major-mode 'open-record-fn))))
-    (cl-assert follow-fn nil "Major mode not in `activity-major-mode-alist': 
%s" major-mode)
-    (funcall follow-fn :buffer buffer :record activity-buffer)))
+  (pcase-let (((cl-struct activity-buffer filename) activity-buffer))
+    (find-file-noselect filename)))
 
 (defun activity--name-buffer (activity-buffer)
   "Return buffer for ACTIVITY-BUFFER having `name' set."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]