emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/listen 294a129ff2 081/103: Revert "Change: (listen-queu


From: ELPA Syncer
Subject: [elpa] externals/listen 294a129ff2 081/103: Revert "Change: (listen-queue--update-buffer) Add REVERTP argument"
Date: Mon, 26 Feb 2024 12:59:31 -0500 (EST)

branch: externals/listen
commit 294a129ff23439dd7d2913edf4bbbd3e0eaf3fc4
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Revert "Change: (listen-queue--update-buffer) Add REVERTP argument"
    
    This reverts commit 66a220243a135aa2e82de14631b57f590011b4e0.
    
    It's necessary to revert the queue to draw the arrow next to the
    current track, which is used to find where to make the overlay.
    
    (Attempts at drawing the arrow without reverting the vtable were
    unsatisfying due to vtable's not getting to take the arrow's width
    into account while drawing the table if it's not present when
    inserting the row.  And attempts to just replace the two rows of the
    old/current track failed due to a weird problem, maybe a bug in
    vtable, not sure.)
---
 README.org      |  1 -
 listen-queue.el | 17 +++++++----------
 listen.info     |  6 ++----
 3 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/README.org b/README.org
index 50d6903644..210730f08b 100644
--- a/README.org
+++ b/README.org
@@ -56,7 +56,6 @@ Use the command ~listen~ to show the Transient menu.  From 
there, it is--hopeful
 
 *Fixes*
 + The queue could sometimes skip tracks when playing.
-+ Don't revert queue buffer when playing next track (just move the highlight).
 
 ** v0.1
 
diff --git a/listen-queue.el b/listen-queue.el
index e90bd0bb1a..22a95dc562 100644
--- a/listen-queue.el
+++ b/listen-queue.el
@@ -183,19 +183,16 @@ If BACKWARDP, move it backward."
       (setf listen-queue-overlay (make-overlay (pos-bol) (pos-eol)))
       (overlay-put listen-queue-overlay 'face 'highlight))))
 
-(cl-defun listen-queue--update-buffer (queue &key (revertp t))
-  "Update QUEUE's buffer, if any.
-When REVERTP, revert the track list; otherwise just highlight the
-current track."
+(defun listen-queue--update-buffer (queue)
+  "Update QUEUE's buffer, if any."
   (when-let ((buffer (cl-loop for buffer in (buffer-list)
                               when (eq queue (buffer-local-value 'listen-queue 
buffer))
                               return buffer)))
     (with-current-buffer buffer
-      (when revertp
-        (save-excursion
-          (goto-char (point-min))
-          (when (vtable-current-table)
-            (vtable-revert-command))))
+      (save-excursion
+        (goto-char (point-min))
+        (when (vtable-current-table)
+          (vtable-revert-command)))
       (listen-queue--highlight-current))))
 
 (declare-function listen-mode "listen")
@@ -214,7 +211,7 @@ select track as well."
     (listen-play player (listen-track-filename track))
     (setf (listen-queue-current queue) track
           (map-elt (listen-player-etc player) :queue) queue)
-    (listen-queue--update-buffer queue :revertp nil))
+    (listen-queue--update-buffer queue))
   (unless listen-mode
     (listen-mode))
   queue)
diff --git a/listen.info b/listen.info
index 3e7f6413a7..4bdc8ca4f7 100644
--- a/listen.info
+++ b/listen.info
@@ -118,8 +118,6 @@ File: README.info,  Node: v02-pre,  Next: v01,  Up: 
Changelog
 
    *Fixes*
    • The queue could sometimes skip tracks when playing.
-   • Don’t revert queue buffer when playing next track (just move the
-     highlight).
 
 
 File: README.info,  Node: v01,  Prev: v02-pre,  Up: Changelog
@@ -151,8 +149,8 @@ Node: Configuration2537
 Node: Usage2876
 Node: Changelog3147
 Node: v02-pre3299
-Node: v013661
-Node: Development3763
+Node: v013570
+Node: Development3672
 
 End Tag Table
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]