[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/listen 294a129ff2 081/103: Revert "Change: (listen-queu
From: |
ELPA Syncer |
Subject: |
[elpa] externals/listen 294a129ff2 081/103: Revert "Change: (listen-queue--update-buffer) Add REVERTP argument" |
Date: |
Mon, 26 Feb 2024 12:59:31 -0500 (EST) |
branch: externals/listen
commit 294a129ff23439dd7d2913edf4bbbd3e0eaf3fc4
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>
Revert "Change: (listen-queue--update-buffer) Add REVERTP argument"
This reverts commit 66a220243a135aa2e82de14631b57f590011b4e0.
It's necessary to revert the queue to draw the arrow next to the
current track, which is used to find where to make the overlay.
(Attempts at drawing the arrow without reverting the vtable were
unsatisfying due to vtable's not getting to take the arrow's width
into account while drawing the table if it's not present when
inserting the row. And attempts to just replace the two rows of the
old/current track failed due to a weird problem, maybe a bug in
vtable, not sure.)
---
README.org | 1 -
listen-queue.el | 17 +++++++----------
listen.info | 6 ++----
3 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/README.org b/README.org
index 50d6903644..210730f08b 100644
--- a/README.org
+++ b/README.org
@@ -56,7 +56,6 @@ Use the command ~listen~ to show the Transient menu. From
there, it is--hopeful
*Fixes*
+ The queue could sometimes skip tracks when playing.
-+ Don't revert queue buffer when playing next track (just move the highlight).
** v0.1
diff --git a/listen-queue.el b/listen-queue.el
index e90bd0bb1a..22a95dc562 100644
--- a/listen-queue.el
+++ b/listen-queue.el
@@ -183,19 +183,16 @@ If BACKWARDP, move it backward."
(setf listen-queue-overlay (make-overlay (pos-bol) (pos-eol)))
(overlay-put listen-queue-overlay 'face 'highlight))))
-(cl-defun listen-queue--update-buffer (queue &key (revertp t))
- "Update QUEUE's buffer, if any.
-When REVERTP, revert the track list; otherwise just highlight the
-current track."
+(defun listen-queue--update-buffer (queue)
+ "Update QUEUE's buffer, if any."
(when-let ((buffer (cl-loop for buffer in (buffer-list)
when (eq queue (buffer-local-value 'listen-queue
buffer))
return buffer)))
(with-current-buffer buffer
- (when revertp
- (save-excursion
- (goto-char (point-min))
- (when (vtable-current-table)
- (vtable-revert-command))))
+ (save-excursion
+ (goto-char (point-min))
+ (when (vtable-current-table)
+ (vtable-revert-command)))
(listen-queue--highlight-current))))
(declare-function listen-mode "listen")
@@ -214,7 +211,7 @@ select track as well."
(listen-play player (listen-track-filename track))
(setf (listen-queue-current queue) track
(map-elt (listen-player-etc player) :queue) queue)
- (listen-queue--update-buffer queue :revertp nil))
+ (listen-queue--update-buffer queue))
(unless listen-mode
(listen-mode))
queue)
diff --git a/listen.info b/listen.info
index 3e7f6413a7..4bdc8ca4f7 100644
--- a/listen.info
+++ b/listen.info
@@ -118,8 +118,6 @@ File: README.info, Node: v02-pre, Next: v01, Up:
Changelog
*Fixes*
• The queue could sometimes skip tracks when playing.
- • Don’t revert queue buffer when playing next track (just move the
- highlight).
File: README.info, Node: v01, Prev: v02-pre, Up: Changelog
@@ -151,8 +149,8 @@ Node: Configuration2537
Node: Usage2876
Node: Changelog3147
Node: v02-pre3299
-Node: v013661
-Node: Development3763
+Node: v013570
+Node: Development3672
End Tag Table
- [elpa] externals/listen e3c23b00f1 073/103: Release: v0.1, (continued)
- [elpa] externals/listen e3c23b00f1 073/103: Release: v0.1, ELPA Syncer, 2024/02/26
- [elpa] externals/listen f4e2d8d71f 084/103: Add: (listen-queue-refresh), ELPA Syncer, 2024/02/26
- [elpa] externals/listen 2ac2eed1fd 082/103: Add: (listen-queue-shell-command), ELPA Syncer, 2024/02/26
- [elpa] externals/listen d84c2e8745 063/103: Library bookmarks, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 6ea353586e 086/103: Release: v0.2, ELPA Syncer, 2024/02/26
- [elpa] externals/listen d41da92402 096/103: Change: (listen-mpd-completing-read) Use completing-read-multiple, ELPA Syncer, 2024/02/26
- [elpa] externals/listen e4cdd0cf6c 064/103: Library and shell command improvements, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 214b87215c 067/103: Fix: (listen-mode-lighter), ELPA Syncer, 2024/02/26
- [elpa] externals/listen d417f11c49 068/103: Tidy, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 1371d14c26 062/103: Update docs, commentary, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 294a129ff2 081/103: Revert "Change: (listen-queue--update-buffer) Add REVERTP argument",
ELPA Syncer <=
- [elpa] externals/listen b515c309ab 046/103: Improve transient, ELPA Syncer, 2024/02/26
- [elpa] externals/listen b9d4fd6c17 071/103: Order queue, faces, etc, ELPA Syncer, 2024/02/26
- [elpa] externals/listen b605713e0c 072/103: Queue fixes, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 6138622ee2 076/103: Fix: (listen-queue-play) Don't reactivate mode, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 30f7f02c74 079/103: Comment: Add TODO, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 66302803b4 038/103: Queue yank/kill, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 66a220243a 077/103: Change: (listen-queue--update-buffer) Add REVERTP argument, ELPA Syncer, 2024/02/26
- [elpa] externals/listen 8d2e0843df 094/103: Add: (listen-library-from-mpd), ELPA Syncer, 2024/02/26
- [elpa] externals/listen a93e82d9f9 088/103: Change: (listen-info--find-stream-type) Improve filename regexps, ELPA Syncer, 2024/02/26
- [elpa] externals/listen f88749bc67 099/103: Fix: (listen--ensure) Unset query-on-exit flag, ELPA Syncer, 2024/02/26