emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org 8bea06ce93 3/6: lisp/org-element.el (org-element--c


From: ELPA Syncer
Subject: [elpa] externals/org 8bea06ce93 3/6: lisp/org-element.el (org-element--cache-active-p): Remove FIXME
Date: Mon, 20 May 2024 09:58:42 -0400 (EDT)

branch: externals/org
commit 8bea06ce93c8191badee477339797eb96d50153d
Author: Ihor Radchenko <yantar92@posteo.net>
Commit: Ihor Radchenko <yantar92@posteo.net>

    lisp/org-element.el (org-element--cache-active-p): Remove FIXME
    
    It is not 100% clear if inlining `org-element--cache-active-p' will
    yield practical improvements.  So, let's not litter the code base with
    such FIXMEs.
---
 lisp/org-element.el | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index 2c6174aca7..071be1dd1e 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -6147,11 +6147,6 @@ This function assumes `org-element--headline-cache' is a 
valid AVL tree."
 
 ;;;; Tools
 
-;; FIXME: Ideally, this should be inlined to avoid overheads, but
-;; inlined functions should be declared before the code that uses them
-;; and some code above does use `org-element--cache-active-p'.  Moving this
-;; declaration on top would require restructuring the whole cache
-;; section.
 (defun org-element--cache-active-p (&optional called-from-cache-change-func-p)
   "Non-nil when cache is active in current buffer.
 When CALLED-FROM-CACHE-CHANGE-FUNC-P is non-nil, do not assert cache



reply via email to

[Prev in Thread] Current Thread [Next in Thread]