emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/cider 3ab2709742: [Fix #3615] Show progress when evaluatin


From: ELPA Syncer
Subject: [nongnu] elpa/cider 3ab2709742: [Fix #3615] Show progress when evaluating files using `cider-load-all-files` (#3714)
Date: Tue, 11 Jun 2024 00:59:31 -0400 (EDT)

branch: elpa/cider
commit 3ab27097424c08a381d3046f09dca8be8bb444b6
Author: Kato Muso <m@katomuso.io>
Commit: GitHub <noreply@github.com>

    [Fix #3615] Show progress when evaluating files using 
`cider-load-all-files` (#3714)
    
    Show progress in echo area while recursively evaluating files in directory 
using cider-load-all-files.
    
    As I've noticed that messages from evaluations keep popping up, so it's 
very hard to see progress message, I've used inhibit-message around 
cider-load-file. One possible downside of this is that error messages are not 
displayed as well (though it will be really hard to notice some error message 
while messages pop up one after the other).
    
    Also, I've tweaked the prompt of cider-load-all-files because it might not 
be clear how files are loaded as the word "beneath" is ambiguous (it may mean 
one level of depth which is not the case).
---
 CHANGELOG.md  |  2 ++
 cider-eval.el | 12 +++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 50373ce2e8..7de93bb2b6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,8 @@
 
 ### Changes
 
+- [#3714](https://github.com/clojure-emacs/cider/pull/3714): Show progress 
when evaluating files using `cider-load-all-files`.
+
 ### Bugs fixed
 
 ## 1.15.0 (2024-06-10)
diff --git a/cider-eval.el b/cider-eval.el
index 7325abde72..0a422fe437 100644
--- a/cider-eval.el
+++ b/cider-eval.el
@@ -1839,9 +1839,15 @@ all ns aliases and var mappings from the namespace 
before reloading it."
 Useful when the running nREPL on remote host.
 When UNDEF-ALL is non-nil or called with \\[universal-argument], removes
 all ns aliases and var mappings from the namespaces being reloaded"
-  (interactive "DLoad files beneath directory: \nP")
-  (mapcar (lambda (file) (cider-load-file file undef-all))
-          (directory-files-recursively directory "\\.clj[cs]?$")))
+  (interactive "DRecursively load files in directory: \nP")
+  (let* ((files (directory-files-recursively directory "\\.clj[cs]?$"))
+         (reporter (make-progress-reporter "Loading files" 0 (length files))))
+    (seq-do-indexed (lambda (file idx)
+                      (let ((inhibit-message t))
+                        (cider-load-file file undef-all))
+                      (progress-reporter-update reporter (1+ idx) file))
+                    files)
+    (progress-reporter-done reporter)))
 
 (defalias 'cider-eval-file #'cider-load-file
   "A convenience alias as some people are confused by the load-* names.")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]