emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/hyperdrive 08bd15b54d 28/42: Fix: (h/seed-url) Fill disk u


From: ELPA Syncer
Subject: [nongnu] elpa/hyperdrive 08bd15b54d 28/42: Fix: (h/seed-url) Fill disk usage after getting URL
Date: Wed, 19 Jun 2024 19:00:02 -0400 (EDT)

branch: elpa/hyperdrive
commit 08bd15b54d1bee1fb3f0fd5890ac6d85da91cda1
Author: Joseph Turner <joseph@ushin.org>
Commit: Joseph Turner <joseph@ushin.org>

    Fix: (h/seed-url) Fill disk usage after getting URL
    
    While it's possible to fill this data in only a single request, I
    think the semantic clarity of calling h/fill explicitly is worth the
    negligible performance hit of making an additional HEAD request.
---
 hyperdrive-lib.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el
index 30181dc6c0..157f70231d 100644
--- a/hyperdrive-lib.el
+++ b/hyperdrive-lib.el
@@ -1351,9 +1351,7 @@ hyperdrive."
             (h/api 'get (format "hyper://localhost/?key=%s"
                                 (url-hexify-string seed))
               :as 'response :noquery t)))
-        ;; TODO: Update hyperdrive disk-usage.  The following doesn't work
-        ;; because the response doesn't have the proper ETag header:
-        ;; (he//fill (h/url-entry url) headers)
+        (h/fill (h/url-entry url))
         url)
     (plz-error (if (= 400 (plz-response-status (plz-error-response (caddr 
err))))
                    ;; FIXME: If plz-error is a curl-error, this block will 
fail.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]