emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/posframe 493b17f74a 4/4: Merge pull request #143 from t


From: ELPA Syncer
Subject: [elpa] externals/posframe 493b17f74a 4/4: Merge pull request #143 from tarsiiformes/minibuf-mode-line
Date: Wed, 3 Jul 2024 00:58:42 -0400 (EDT)

branch: externals/posframe
commit 493b17f74ad41104d0c4d648e8c96dc495279ac8
Merge: f4e9e509ba 9be0ccfc7b
Author: tumashu <tumashu@163.com>
Commit: GitHub <noreply@github.com>

    Merge pull request #143 from tarsiiformes/minibuf-mode-line
    
    posframe-show: Take mode-line-height into account from minibuffer
---
 posframe.el | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/posframe.el b/posframe.el
index 1051354979..de92d7d9ec 100644
--- a/posframe.el
+++ b/posframe.el
@@ -126,7 +126,7 @@ effect.")
        (not (or noninteractive
                 emacs-basic-display
                 (not (display-graphic-p))
-               (eq (frame-parameter (selected-frame) 'minibuffer) 'only)))))
+                (eq (frame-parameter (selected-frame) 'minibuffer) 'only)))))
 
 ;;;###autoload
 (cl-defun posframe-show (buffer-or-name
@@ -404,7 +404,9 @@ You can use `posframe-delete-all' to delete all posframes."
          (font-width (default-font-width))
          (font-height (with-current-buffer (window-buffer parent-window)
                         (posframe--get-font-height position)))
-         (mode-line-height (window-mode-line-height))
+         (mode-line-height (window-mode-line-height
+                            (and (window-minibuffer-p)
+                                 (ignore-errors (window-in-direction 
'above)))))
          (minibuffer-height (window-pixel-height (minibuffer-window)))
          (header-line-height (window-header-line-height parent-window))
          (tab-line-height (if (functionp 'window-tab-line-height)
@@ -710,7 +712,7 @@ ACCEPT-FOCUS."
          (or font (face-attribute 'default :font parent-frame)))
         (when border-color
           (if parent-frame
-             (set-face-background
+              (set-face-background
                (if (facep 'child-frame-border)
                    'child-frame-border
                  'internal-border)
@@ -1286,13 +1288,13 @@ The structure of INFO can be found in docstring of
 (defun posframe-poshandler-frame-top-left-or-right-other-corner (info)
   "Posframe's position handler.
 
-This poshandler function let posframe align to top left or top right corner of 
frame,
-based on whether current window is relatively at left or right in the current 
frame.
-If window is at left, place posframe on right, and vice versa.
-(This is calculated by whether current window center is left or right to frame 
center)
+This poshandler function let posframe align to top left or top right
+corner of frame, based on whether current window is relatively at left
+or right in the current frame.  If window is at left, place posframe on
+right, and vice versa.  (This is calculated by whether current window
+center is left or right to frame center.)
 
-The structure of INFO can be found in docstring of
-`posframe-show'."
+The structure of INFO can be found in docstring of `posframe-show'."
   (let ((window-left (plist-get info :parent-window-left))
         (window-width (plist-get info :parent-window-width))
         (frame-width (plist-get info :parent-frame-width)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]