[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/geiser 410a3a50d7 2/2: further clarifications re geiser-cu
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/geiser 410a3a50d7 2/2: further clarifications re geiser-custom |
Date: |
Fri, 5 Jul 2024 09:59:56 -0400 (EDT) |
branch: elpa/geiser
commit 410a3a50d724c0aaf8d209d6a620976828854881
Author: jao <jao@gnu.org>
Commit: jao <jao@gnu.org>
further clarifications re geiser-custom
A note on why we won't use the mapatom trick to make
geiser-custom--defcustom
obsolete while still preserving geiser-reload functionality (cf. !22).
---
elisp/geiser-custom.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/elisp/geiser-custom.el b/elisp/geiser-custom.el
index 7125f11ecf..f9b05a703a 100644
--- a/elisp/geiser-custom.el
+++ b/elisp/geiser-custom.el
@@ -47,9 +47,12 @@ in the macro arguments."
(defvar geiser-custom--memoized-vars nil)
(defun geiser-custom--memoize (name)
- ;; FIXME: Why not build this list with mapatoms, filtering on a "\\`'geiser-"
+ ;; Why not build this list with mapatoms, filtering on a "\\`'geiser-"
;; prefix and checking that it's a `defcustom', so we don't need
- ;; `geiser-custom--defcustom'?
+ ;; `geiser-custom--defcustom'? Because implementation-specific modules using
+ ;; geiser may use similarly named custom variables that are, for some reason
+ ;; or another, not meant to partake in the geiser-reload mechanism, and we
+ ;; don't know their names.
(add-to-list 'geiser-custom--memoized-vars name))
(defmacro geiser-custom--defcustom (name &rest body)