emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/dslide 67d35380e5 142/230: clean up dslide--stop


From: ELPA Syncer
Subject: [nongnu] elpa/dslide 67d35380e5 142/230: clean up dslide--stop
Date: Sun, 7 Jul 2024 19:00:28 -0400 (EDT)

branch: elpa/dslide
commit 67d35380e54f9eeecf12a7b3125cc4c7be682627
Author: Psionik K <73710933+psionic-k@users.noreply.github.com>
Commit: Psionik K <73710933+psionic-k@users.noreply.github.com>

    clean up dslide--stop
    
    has been behaving well and the comments are no longer valid
    
    Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
---
 dslide.el | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/dslide.el b/dslide.el
index de4b10cb38..ecad9d0b69 100644
--- a/dslide.el
+++ b/dslide.el
@@ -2621,27 +2621,17 @@ source buffer."
   (when-let* ((deck dslide--deck)
               (slide-buffer (oref deck slide-buffer))
               (base-buffer (oref deck base-buffer)))
-
-    ;; TODO possibly finalize in state cleanup.  Slides <-> contents switching
-    ;; may require attention.
     (with-demoted-errors "Deck finalization failed: %s"
       (dslide-final dslide--deck))
-
     ;; Animation timers especially should be stopped
-    ;; TODO ensure cleanup is thorough even if there's a lot of failures.
     (dslide--cleanup-state)
-
-    (setq dslide--deck nil)
-
-    (display-buffer base-buffer dslide--display-actions)
-    (set-buffer base-buffer)
-
     (when slide-buffer
       (kill-buffer slide-buffer))
-
+    (display-buffer base-buffer dslide--display-actions)
+    (set-buffer base-buffer)
+    (setq dslide--deck nil)
     (when dslide-mode
       (dslide-mode -1))
-
     (run-hooks 'dslide-stop-hook)
     (dslide--feedback :stop)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]