emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/corfu c1d75d3cd1 5/5: Update comment


From: ELPA Syncer
Subject: [elpa] externals/corfu c1d75d3cd1 5/5: Update comment
Date: Wed, 10 Jul 2024 06:57:44 -0400 (EDT)

branch: externals/corfu
commit c1d75d3cd18d770f869b5e3317c437a1557711ce
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Update comment
---
 corfu.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/corfu.el b/corfu.el
index 5da53f767e..51b03b8c3c 100644
--- a/corfu.el
+++ b/corfu.el
@@ -716,7 +716,9 @@ FRAME is the existing frame."
 
 (defun corfu--metadata-get (prop)
   "Return PROP from completion metadata."
-  ;; Marginalia are too heavy for Corfu. Use `completion-metadata-get' without 
advices.
+  ;; Marginalia and various icon packages advise `completion-metadata-get' to
+  ;; inject their annotations, but are meant only for minibuffer completion.
+  ;; Therefore call `completion-metadata-get' without advices here.
   (let ((completion-extra-properties (nth 4 completion-in-region--data)))
     (funcall (advice--cd*r (symbol-function (compat-function 
completion-metadata-get)))
              corfu--metadata prop)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]