emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/svg-tag-mode 7f42a443e9 11/12: Revert "Added a match-da


From: ELPA Syncer
Subject: [elpa] externals/svg-tag-mode 7f42a443e9 11/12: Revert "Added a match-data on tag that can be retrieved by callback"
Date: Wed, 28 Aug 2024 06:59:00 -0400 (EDT)

branch: externals/svg-tag-mode
commit 7f42a443e9dc0fcd51d8f85594c3afd0cac3cf15
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Revert "Added a match-data on tag that can be retrieved by callback"
    
    This reverts commit 0e0ea48799d8911ed6c1ef60565a20fd5cf3dae4.
    
    At the time `match-string' is evaluated it, at least sometimes,
    returns nil (I suspect it always does), which then causes
    `substring-no-properties' to error because it expects a string
    as argument.
    
    Alternatively, if this happens to actually return non-nil in
    some cases, then `match-string-no-properties' should be used
    instead, because, like `match-string', that won't error when
    the requested match-data is empty.
---
 svg-tag-mode.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/svg-tag-mode.el b/svg-tag-mode.el
index 05a24cea39..a7f58403fc 100644
--- a/svg-tag-mode.el
+++ b/svg-tag-mode.el
@@ -254,7 +254,6 @@ Action can be:
          (help     (nth 2 (cdr item))))
     (setq tag ``( face nil
                   display ,,tag
-                  match-data ,(substring-no-properties (match-string 1))
                   cursor-sensor-functions (svg-tag--cursor-function)
                   ,@(and ,callback '(pointer hand))
                   ,@(and ,help `(help-echo ,,help))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]