emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/gnosis 02a4e13520 12/19: [fix] display-images: Display ima


From: ELPA Syncer
Subject: [nongnu] elpa/gnosis 02a4e13520 12/19: [fix] display-images: Display images only on graphical envs.
Date: Thu, 5 Sep 2024 13:00:31 -0400 (EDT)

branch: elpa/gnosis
commit 02a4e1352025e023d4345cd7dd71ae063d396538
Author: Thanos Apollo <public@thanosapollo.org>
Commit: Thanos Apollo <public@thanosapollo.org>

    [fix] display-images: Display images only on graphical envs.
    
    * Fix issues for running gnosis on tty & termux.
---
 gnosis.el | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/gnosis.el b/gnosis.el
index caef741d52..db5a6f4c85 100644
--- a/gnosis.el
+++ b/gnosis.el
@@ -484,19 +484,21 @@ or =extra-image'.  Instead of using =extra-image' post 
review, prefer
 =gnosis-display-extra' which displays the =extra-image' as well.
 
 Refer to =gnosis-db-schema-extras' for informations on images stored."
-  (let* ((img (gnosis-get image 'extras `(= id ,id)))
-         (path-to-image (expand-file-name (or img "") (file-name-as-directory 
gnosis-images-dir)))
-         (image (create-image path-to-image 'png nil :width gnosis-image-width 
:height gnosis-image-height))
-         (image-width (car (image-size image t)))
-         (frame-width (window-text-width))) ;; Width of the current window in 
columns
-    (cond ((or (not img) (string-empty-p img))
-           (insert "\n\n"))
-          ((and img (file-exists-p path-to-image))
-           (let* ((padding-cols (/ (- frame-width (floor (/ image-width 
(frame-char-width)))) 2))
-                  (padding (make-string (max 0 padding-cols) ?\s)))
-             (insert "\n\n" padding)  ;; Insert padding before the image
-             (insert-image image)
-             (insert "\n\n"))))))
+  ;; Only display images on graphical env
+  (when (display-graphic-p)
+    (let* ((img (gnosis-get image 'extras `(= id ,id)))
+           (path-to-image (expand-file-name (or img "") 
(file-name-as-directory gnosis-images-dir)))
+           (image (create-image path-to-image 'png nil :width 
gnosis-image-width :height gnosis-image-height))
+           (image-width (car (image-size image t)))
+           (frame-width (window-text-width))) ;; Width of the current window 
in columns
+      (cond ((or (not img) (string-empty-p img))
+             (insert "\n\n"))
+            ((and img (file-exists-p path-to-image))
+             (let* ((padding-cols (/ (- frame-width (floor (/ image-width 
(frame-char-width)))) 2))
+                    (padding (make-string (max 0 padding-cols) ?\s)))
+               (insert "\n\n" padding)  ;; Insert padding before the image
+               (insert-image image)
+               (insert "\n\n")))))))
 
 (defun gnosis-display-mcq-options (id)
   "Display answer options for mcq note ID."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]