[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 1b7f9be7b9 6/8: transient-suffix-object: Drop
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 1b7f9be7b9 6/8: transient-suffix-object: Drop faulty fallback behavior |
Date: |
Sat, 2 Nov 2024 09:09:39 -0400 (EDT) |
branch: externals/transient
commit 1b7f9be7b9fbc8acb5d71f028b19e1f78d9dd090
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient-suffix-object: Drop faulty fallback behavior
We can only forgo looking for an object whose binding matches if there
is only a single object whose command matches. If the binding match
fails, there is a bug somewhere, such as the one fixed in the previous
commit.
---
lisp/transient.el | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index cb4243d511..9623345e82 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1702,13 +1702,14 @@ probably use this instead:
this-command))))
(or transient--suffixes
transient-current-suffixes))))
- (or (and (cdr suffixes)
- (cl-find-if
- (lambda (obj)
- (equal (listify-key-sequence (transient--kbd (oref obj key)))
- (listify-key-sequence (this-command-keys))))
- suffixes))
- (car suffixes))))
+ (or (if (cdr suffixes)
+ (cl-find-if
+ (lambda (obj)
+ (equal (listify-key-sequence (transient--kbd (oref obj key)))
+ (listify-key-sequence (this-command-keys))))
+ suffixes)
+ (car suffixes))
+ (error "BUG: Cannot determine suffix object"))))
((and-let* ((obj (transient--suffix-prototype (or command this-command)))
(obj (clone obj)))
(progn ; work around debbugs#31840
- [elpa] externals/transient updated (fcc54cb5d1 -> d6b52b6eb7), Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient dd91827b41 3/8: Update changelog, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient cb11650a60 2/8: Show information about the suffix at point in the echo area, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient 0ed0094919 4/8: Ensure transient-current-* variables are unset on every exit, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient 1b7f9be7b9 6/8: transient-suffix-object: Drop faulty fallback behavior,
Jonas Bernoulli <=
- [elpa] externals/transient d9ced840fa 5/8: transient--make-redisplay-map: Ensure unread-command-events is used, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient 03f9f314cd 7/8: Re-generate manual, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient d6b52b6eb7 8/8: Release version 0.7.8, Jonas Bernoulli, 2024/11/02
- [elpa] externals/transient 38f7f46826 1/8: transient-enable-popup-navigation: Update documentation, Jonas Bernoulli, 2024/11/02