[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/helm dd059c1f70 2/3: Remove unneeded checks of helm--minib
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/helm dd059c1f70 2/3: Remove unneeded checks of helm--minibuffer-completing-file-name and |
Date: |
Wed, 13 Nov 2024 04:00:09 -0500 (EST) |
branch: elpa/helm
commit dd059c1f7022391466ac339c2c64bad5a30c498c
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>
Remove unneeded checks of helm--minibuffer-completing-file-name and
update docstring.
---
helm-core.el | 4 +++-
helm-mode.el | 5 +----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/helm-core.el b/helm-core.el
index c436c7f6f5..12d2d3f76c 100644
--- a/helm-core.el
+++ b/helm-core.el
@@ -198,7 +198,9 @@ window handling a buffer, it is this one we store.")
"[INTERNAL] Recenter when deleting minibuffer-contents and preselecting.
This is a flag used internally.")
(defvar helm--minibuffer-completing-file-name nil
- "Same as `minibuffer-completing-file-name' but doesn't affect
`file-directory-p'.")
+ "A flag notifying Helm is in file completion.
+It is let-bounded in `helm-read-file-name'. Same as
+`minibuffer-completing-file-name' but doesn't affect `file-directory-p'.")
;;; Multi keys
;;
diff --git a/helm-mode.el b/helm-mode.el
index 8f722866d8..a9aef61185 100644
--- a/helm-mode.el
+++ b/helm-mode.el
@@ -545,7 +545,6 @@ If COLLECTION is an `obarray', a TEST should be needed. See
`obarray'."
;; Handle here specially such cases.
((and (functionp collection) (not (string= input ""))
(or minibuffer-completing-file-name
- helm--minibuffer-completing-file-name
(eq (completion-metadata-get
(completion-metadata input collection test)
'category)
@@ -2436,7 +2435,6 @@ Currently does nothing."
(let* ((split (helm-mm-split-pattern string))
(fpat (or (car split) ""))
(file-comp-p (or minibuffer-completing-file-name
- helm--minibuffer-completing-file-name
(eq
(completion-metadata-get
(completion-metadata string collection predicate)
@@ -2528,8 +2526,7 @@ Currently does nothing."
(unless (string-match-p " " string)
(cl-multiple-value-bind (all pattern prefix suffix _carbounds)
(helm-completion--flex-all-completions string table pred point)
- (when (or minibuffer-completing-file-name
- helm--minibuffer-completing-file-name)
+ (when minibuffer-completing-file-name
(setq all (completion-pcm--filename-try-filter all)))
(completion-pcm--merge-try pattern all prefix suffix))))