emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dape 8afd879b77 2/2: Remove unused config value check


From: ELPA Syncer
Subject: [elpa] externals/dape 8afd879b77 2/2: Remove unused config value check
Date: Fri, 22 Nov 2024 15:57:53 -0500 (EST)

branch: externals/dape
commit 8afd879b77a7585fe2cd55fdcf1b1181f1214077
Author: Daniel Pettersson <daniel@dpettersson.net>
Commit: Daniel Pettersson <daniel@dpettersson.net>

    Remove unused config value check
---
 dape.el | 36 +++++++++++++++---------------------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/dape.el b/dape.el
index ca95c5cef4..056066f717 100644
--- a/dape.el
+++ b/dape.el
@@ -4900,7 +4900,7 @@ Update `dape--inlay-hint-overlays' from SCOPES."
             (with-current-buffer dape--minibuffer-last-buffer
               (condition-case err
                   (propertize
-                   (format "%S" (dape--config-eval-value value nil nil 
'skip-interactive))
+                   (format "%S" (dape--config-eval-value value nil 
'skip-interactive))
                    'face
                    (when (equal value (plist-get base-config key))
                      'shadow))
@@ -4941,13 +4941,12 @@ Update `dape--inlay-hint-overlays' from SCOPES."
   "Non-nil if and only if OBJECT is a valid plist."
   (and (listp object) (zerop (% (length object) 2))))
 
-(defun dape--config-eval-value (value &optional skip-functions check
-                                      skip-interactive)
+(defun dape--config-eval-value (value &optional skip-functions 
skip-interactive)
   "Return recursively evaluated VALUE.
-If SKIP-FUNCTIONS is non nil return VALUE as is if `functionp' is non
-nil.  If CHECK is non nil assert VALUE types, signal `user-error' on
-mismatch.  If SKIP-INTERACTIVE is non nil return VALUE as is if
-`functionp' is non nil and function uses the minibuffer."
+If SKIP-FUNCTIONS is non nil return VALUE as is if `functionp' is
+non nil.
+If SKIP-INTERACTIVE is non nil return VALUE as is if `functionp' is
+non nil and function uses the minibuffer."
   (pcase value
     ;; On function (or list that starts with a non keyword symbol)
     ((or (pred functionp)
@@ -4963,36 +4962,31 @@ mismatch.  If SKIP-INTERACTIVE is non nil return VALUE 
as is if
          (error value))))
     ;; On plist recursively evaluate
     ((pred dape--plistp)
-     (dape--config-eval-1 value skip-functions check skip-interactive))
+     (dape--config-eval-1 value skip-functions skip-interactive))
     ;; On vector evaluate each item
     ((pred vectorp)
      (cl-map 'vector
              (lambda (value)
-               (dape--config-eval-value value skip-functions check
-                                        skip-interactive))
+               (dape--config-eval-value value skip-functions skip-interactive))
              value))
     ;; On symbol evaluate symbol value
     ((and (pred symbolp)
           ;; Guard against infinite recursion
           (guard (not (eq (symbol-value value) value))))
-     (dape--config-eval-value (symbol-value value)
-                              skip-functions check skip-interactive))
+     (dape--config-eval-value (symbol-value value) skip-functions
+                              skip-interactive))
     ;; Otherwise just value
     (_ value)))
 
-(defun dape--config-eval-1 (config &optional skip-functions check
-                                   skip-interactive)
-  "Helper for `dape--config-eval'."
+(defun dape--config-eval-1 (config &optional skip-functions skip-interactive)
+  "Return evaluated CONFIG.
+See `dape--config-eval' for SKIP-FUNCTIONS and SKIP-INTERACTIVE."
   (cl-loop for (key value) on config by 'cddr append
            (cond
             ((memql key '(modes fn ensure)) (list key value))
-            ((and check (not (keywordp key)))
-             (user-error "Unexpected key %S; lists of things needs be \
-arrays [%S ...], if meant as an object replace (%S ...) with (:%s ...)"
-                         key key key key))
             ((list key
-                   (dape--config-eval-value value skip-functions
-                                            (or check (keywordp key))
+                   (dape--config-eval-value value
+                                            skip-functions
                                             skip-interactive))))))
 (defun dape--config-eval (key options)
   "Evaluate config with KEY and OPTIONS."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]