emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/magit 961b966f9a 25/28: Require magit-process for the bene


From: Jonas Bernoulli
Subject: [nongnu] elpa/magit 961b966f9a 25/28: Require magit-process for the benefit of magit-auto-revert-mode
Date: Fri, 6 Dec 2024 17:17:05 -0500 (EST)

branch: elpa/magit
commit 961b966f9a350bbe30d5ed54ad255d3b2a9a6fc5
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Require magit-process for the benefit of magit-auto-revert-mode
    
    To avoid circular dependencies, `magit-git' does not require
    `magit-process', even though it uses functions from that.  Normally
    that works fine because using pretty much every feature of Magit,
    causes both of these libraries to be loaded.
    
    However, because it is autoloaded, a user may call
    `magit-auto-revert-mode' in their init file, without loading Magit
    first (or doing anything that triggers Magit to be loaded).  In this
    case `magit-autorevert' is loaded, but not `magit', which would load
    all the parts of Magit whose loading cannot be delayed.
    
    Previously `magit-autorevert' required `magit-git', so that was
    loaded too.  Now it requires `magit-process', causing all three
    libraries to be loaded.
    
    Users do not actually have to enable `magit-auto-revert-mode' in
    their init file, because it is enabled by default.  Disabling the
    mode did not cause an issue and it's valid to do that in the init
    file.
    
    Closes #5263.
---
 lisp/magit-autorevert.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/magit-autorevert.el b/lisp/magit-autorevert.el
index 5a38d9f679..36f1678238 100644
--- a/lisp/magit-autorevert.el
+++ b/lisp/magit-autorevert.el
@@ -22,7 +22,7 @@
 
 ;;; Code:
 
-(require 'magit-git)
+(require 'magit-process)
 
 (require 'autorevert)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]